fix: Align allowed origins with validateOrigin logic #8027

tjcuddihy · 2025-12-02T03:23:00Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

The default values for KueueViz offer frontend.kueueviz.local as the KUEUEVIZ_ALLOWED_ORIGIN.

However, the origins are validated here which has a specific check to ensure that the url has a scheme of either HTTP or HTTPS. I.e. the provided default value is invalid.

This PR updates the default value to have a passing value.

Which issue(s) this PR fixes:

Fixes #8028

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

cmd/kueueviz/backend/middleware/cors.go requires candidate origins to have a valid HTTP or HTTPS scheme.

k8s-ci-robot · 2025-12-02T03:23:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tjcuddihy
Once this PR has been reviewed and has the lgtm label, please assign gabesaba for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

linux-foundation-easycla · 2025-12-02T03:23:07Z

The committers listed above are authorized under a signed CLA.

✅ login: tjcuddihy / name: Tom Cuddihy (985a111, f9d9834)

k8s-ci-robot · 2025-12-02T03:23:08Z

Welcome @tjcuddihy!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-12-02T03:23:09Z

Hi @tjcuddihy. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

netlify · 2025-12-02T03:23:23Z

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	`f9d9834`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/692fae7878c64e0008a574e3

mbobrovskyi · 2025-12-02T05:22:33Z

/ok-to-test

mbobrovskyi · 2025-12-02T05:27:19Z

charts/kueue/values.yaml

Please also update here.

mbobrovskyi · 2025-12-02T05:30:40Z

charts/kueue/values.yaml

    env:
      - name: KUEUEVIZ_ALLOWED_ORIGINS
-        value: "frontend.kueueviz.local"
+        value: "http://frontend.kueueviz.local"


Suggested change

value: "http://frontend.kueueviz.local"

value: "https://frontend.kueueviz.local"

Shouldn't it be https?

Yeah, good catch; You're right, the default in values.yaml configuration has ssl-redirect: "true".

I've now changed it

mbobrovskyi · 2025-12-02T05:31:07Z

Please apply CLA.

mbobrovskyi · 2025-12-02T05:34:35Z

charts/kueue/values.yaml

I also noticed that we’re missing charts/kueue/README.md. Please generate it by running make generate-helm-docs.

tjcuddihy · 2025-12-03T03:39:01Z

/retest

tjcuddihy · 2025-12-03T22:18:56Z

@mbobrovskyi ready for rereview

mbobrovskyi · 2025-12-04T04:43:31Z

/lgtm
Thank you!

k8s-ci-robot · 2025-12-04T04:43:38Z

LGTM label has been added.

Git tree hash: d9b8a31477d680544375de4b50b9fc4dbc86e63a

fix: Align allowed origins with validateOrigin logic

985a111

cmd/kueueviz/backend/middleware/cors.go requires candidate origins to have a valid HTTP or HTTPS scheme.

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Dec 2, 2025

k8s-ci-robot requested review from PBundyra and tenzen-y December 2, 2025 03:23

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2025

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 2, 2025

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2025

mbobrovskyi reviewed Dec 2, 2025

View reviewed changes

charts/kueue/values.yaml

Copy link

Contributor

mbobrovskyi Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update here.

mbobrovskyi reviewed Dec 2, 2025

View reviewed changes

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 2, 2025

feat: Switch to HTTPS

f9d9834

k8s-ci-robot assigned mbobrovskyi Dec 4, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2025

	value: "http://frontend.kueueviz.local"
	value: "https://frontend.kueueviz.local"

fix: Align allowed origins with validateOrigin logic #8027

Are you sure you want to change the base?

fix: Align allowed origins with validateOrigin logic #8027

Uh oh!

Conversation

tjcuddihy commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Uh oh!

k8s-ci-robot commented Dec 2, 2025

Uh oh!

linux-foundation-easycla bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Dec 2, 2025

Uh oh!

k8s-ci-robot commented Dec 2, 2025

Uh oh!

netlify bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Uh oh!

mbobrovskyi commented Dec 2, 2025

Uh oh!

mbobrovskyi Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

mbobrovskyi Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

tjcuddihy Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

mbobrovskyi commented Dec 2, 2025

Uh oh!

mbobrovskyi Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tjcuddihy commented Dec 3, 2025

Uh oh!

tjcuddihy commented Dec 3, 2025

Uh oh!

mbobrovskyi commented Dec 4, 2025

Uh oh!

k8s-ci-robot commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tjcuddihy commented Dec 2, 2025 •

edited

Loading

linux-foundation-easycla bot commented Dec 2, 2025 •

edited

Loading

netlify bot commented Dec 2, 2025 •

edited

Loading

mbobrovskyi Dec 2, 2025 •

edited

Loading