Skip to content

Commit 57813fe

Browse files
authored
Merge pull request #810 from tjamet/metadata/cleanup
Delete unused metadata functions
2 parents b869a81 + 0658a00 commit 57813fe

File tree

2 files changed

+2
-30
lines changed

2 files changed

+2
-30
lines changed

pkg/graph/builder.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ func (b *Builder) buildInstanceResource(
465465
// CRD declarations.
466466

467467
// The instance resource is a Kubernetes resource, so it has a GroupVersionKind.
468-
gvk := metadata.GetResourceGraphDefinitionInstanceGVK(group, apiVersion, kind)
468+
gvr := metadata.GetResourceGraphDefinitionInstanceGVR(group, apiVersion, kind)
469469

470470
// The instance resource has a schema defined using the "SimpleSchema" format.
471471
instanceSpecSchema, err := buildInstanceSpecSchema(rgDefinition)
@@ -497,7 +497,7 @@ func (b *Builder) buildInstanceResource(
497497
// The instance resource has a set of variables that need to be resolved.
498498
instance := &Resource{
499499
id: "instance",
500-
gvr: metadata.GVKtoGVR(gvk),
500+
gvr: gvr,
501501
schema: instanceSchema,
502502
crd: instanceCRD,
503503
}

pkg/metadata/groupversion.go

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,6 @@ func ExtractGVKFromUnstructured(unstructured map[string]interface{}) (schema.Gro
5959
}, nil
6060
}
6161

62-
func GetResourceGraphDefinitionInstanceGVK(group, apiVersion, kind string) schema.GroupVersionKind {
63-
//pluralKind := flect.Pluralize(strings.ToLower(kind))
64-
65-
return schema.GroupVersionKind{
66-
Group: group,
67-
Version: apiVersion,
68-
Kind: kind,
69-
}
70-
}
71-
7262
func GetResourceGraphDefinitionInstanceGVR(group, apiVersion, kind string) schema.GroupVersionResource {
7363
pluralKind := flect.Pluralize(strings.ToLower(kind))
7464
return schema.GroupVersionResource{
@@ -77,21 +67,3 @@ func GetResourceGraphDefinitionInstanceGVR(group, apiVersion, kind string) schem
7767
Resource: pluralKind,
7868
}
7969
}
80-
81-
func GVRtoGVK(gvr schema.GroupVersionResource) schema.GroupVersionKind {
82-
singular := flect.Singularize(gvr.Resource)
83-
return schema.GroupVersionKind{
84-
Group: gvr.Group,
85-
Version: gvr.Version,
86-
Kind: singular,
87-
}
88-
}
89-
90-
func GVKtoGVR(gvk schema.GroupVersionKind) schema.GroupVersionResource {
91-
resource := flect.Pluralize(strings.ToLower(gvk.Kind))
92-
return schema.GroupVersionResource{
93-
Group: gvk.Group,
94-
Version: gvk.Version,
95-
Resource: resource,
96-
}
97-
}

0 commit comments

Comments
 (0)