Fix lint errors (#567)

* Fix lint errors
* Update pkg/controller/instance/controller_reconcile.go
* Add openApi key types constants

Author: DhairyaMajmudar

pkg/controller/instance/controller_reconcile.go

@@ -439,7 +439,7 @@ func (igr *instanceGraphReconciler) finalizeDeletion(ctx context.Context) error
 }
 
 // setManaged ensures the instance has the necessary finalizer and labels.
-func (igr *instanceGraphReconciler) setManaged(ctx context.Context, obj *unstructured.Unstructured, uid types.UID) (*unstructured.Unstructured, error) {
+func (igr *instanceGraphReconciler) setManaged(ctx context.Context, obj *unstructured.Unstructured, _ types.UID) (*unstructured.Unstructured, error) {
 	if exist, _ := metadata.HasInstanceFinalizerUnstructured(obj); exist {
 		return obj, nil
 	}

pkg/dynamiccontroller/dynamic_controller.go

@@ -463,9 +463,12 @@ func (dc *DynamicController) StartServingGVK(ctx context.Context, gvr schema.Gro
 		dc.log.Error(err, "Failed to add event handler", "gvr", gvr)
 		return fmt.Errorf("failed to add event handler for GVR %s: %w", gvr, err)
 	}
-	informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
+	if err := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
 		dc.log.Error(err, "Watch error", "gvr", gvr)
-	})
+	}); err != nil {
+		dc.log.Error(err, "Failed to set watch error handler", "gvr", gvr)
+		return fmt.Errorf("failed to set watch error handler for GVR %s: %w", gvr, err)
+	}
 	dc.handlers.Store(gvr, handler)
 
 	informerContext := context.Background()

pkg/graph/schema/field_descriptor.go

@@ -66,7 +66,7 @@ type fieldDescriptor struct {
 	// The path is typically found by calling `parser.ParseSchemalessResource` see the
 	// `typesystem/parser` package for more information.
 	Path string
-	// Schema is the schema for the field. This is typically inferred by dry runing
+	// Schema is the schema for the field. This is typically inferred by dry running
 	// the CEL expression that generates the field value, then converting the result
 	// into an OpenAPI schema.
 	Schema *extv1.JSONSchemaProps

pkg/simpleschema/transform.go

@@ -23,7 +23,14 @@ import (
 	extv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
 )
 
-// A predefined type is a type that is predefined in the schema.
+const (
+	keyTypeString  = string(AtomicTypeString)
+	keyTypeInteger = string(AtomicTypeInteger)
+	keyTypeBoolean = string(AtomicTypeBool)
+	keyTypeNumber  = "number"
+)
+
+// A predefinedType is a type that is predefined in the schema.
 // It is used to resolve references in the schema, while capturing the fact
 // whether the type has the required marker set (this information would
 // otherwise be lost in the parsing process).
@@ -112,7 +119,7 @@ func (tf *transformer) parseFieldSchema(key, fieldValue string, parentSchema *ex
 	fieldJSONSchemaProps := &extv1.JSONSchemaProps{}
 
 	if isAtomicType(fieldType) {
-		fieldJSONSchemaProps.Type = string(fieldType)
+		fieldJSONSchemaProps.Type = fieldType
 	} else if isCollectionType(fieldType) {
 		if isMapType(fieldType) {
 			fieldJSONSchemaProps, err = tf.handleMapType(key, fieldType)
@@ -147,7 +154,7 @@ func (tf *transformer) handleMapType(key, fieldType string) (*extv1.JSONSchemaPr
 	if err != nil {
 		return nil, fmt.Errorf("failed to parse map type for %s: %w", key, err)
 	}
-	if keyType != "string" {
+	if keyType != keyTypeString {
 		return nil, fmt.Errorf("unsupported key type for maps: %s", keyType)
 	}
 
@@ -215,9 +222,9 @@ func (tf *transformer) applyMarkers(schema *extv1.JSONSchemaProps, markers []*Ma
 		case MarkerTypeDefault:
 			var defaultValue []byte
 			switch schema.Type {
-			case "string":
+			case keyTypeString:
 				defaultValue = []byte(fmt.Sprintf("\"%s\"", marker.Value))
-			case "integer", "number", "boolean":
+			case keyTypeInteger, keyTypeNumber, keyTypeBoolean:
 				defaultValue = []byte(marker.Value)
 			default:
 				defaultValue = []byte(marker.Value)
@@ -260,9 +267,9 @@ func (tf *transformer) applyMarkers(schema *extv1.JSONSchemaProps, markers []*Ma
 
 				var rawValue []byte
 				switch schema.Type {
-				case "string":
+				case keyTypeString:
 					rawValue = []byte(fmt.Sprintf("%q", val))
-				case "integer":
+				case keyTypeInteger:
 					if _, err := strconv.ParseInt(val, 10, 64); err != nil {
 						return fmt.Errorf("failed to parse integer enum value: %w", err)
 					}