Skip to content

Commit 006e1d0

Browse files
authored
Merge pull request #148 from a-hilaly/emulation/rawextensions
parser: Add support for `x-kubernetes-preserve-unknown-fields` schema extension
2 parents 81ddf9c + 52e9b28 commit 006e1d0

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

internal/graph/parser/parser.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ import (
2222
"github.com/awslabs/kro/internal/graph/variable"
2323
)
2424

25+
const (
26+
xKubernetesPreserveUnknownFields = "x-kubernetes-preserve-unknown-fields"
27+
)
28+
2529
// ParseResource extracts CEL expressions from a resource based on
2630
// the schema. The resource is expected to be a map[string]interface{}.
2731
//
@@ -88,6 +92,15 @@ func parseObject(field map[string]interface{}, schema *spec.Schema, path, expect
8892
return nil, fmt.Errorf("expected object type or AdditionalProperties allowed for path %s, got %v", path, field)
8993
}
9094

95+
// Look for vendor schema extensions first
96+
if len(schema.VendorExtensible.Extensions) > 0 {
97+
// If the schema has the x-kubernetes-preserve-unknown-fields extension, we should not
98+
// parse the object and return an empty list of expressions.
99+
if enabled, ok := schema.VendorExtensible.Extensions[xKubernetesPreserveUnknownFields]; ok && enabled.(bool) {
100+
return nil, nil
101+
}
102+
}
103+
91104
var expressionsFields []variable.FieldDescriptor
92105
for fieldName, value := range field {
93106
fieldSchema, err := getFieldSchema(schema, fieldName)

internal/graph/parser/parser_test.go

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,21 @@ func TestParserEdgeCases(t *testing.T) {
618618
},
619619
expectedError: "",
620620
},
621+
{
622+
name: "schema with x-kubernetes-preserve-unknown-fields",
623+
schema: &spec.Schema{
624+
SchemaProps: spec.SchemaProps{
625+
Type: []string{"object"},
626+
},
627+
VendorExtensible: spec.VendorExtensible{
628+
Extensions: spec.Extensions{
629+
"x-kubernetes-preserve-unknown-fields": true,
630+
},
631+
},
632+
},
633+
resource: map[string]interface{}{"name": "John", "age": 30},
634+
expectedError: "",
635+
},
621636
}
622637

623638
for _, tc := range testCases {

0 commit comments

Comments
 (0)