fix: merged the shadow and rollout configs in HS<>UCS tunnel #10473
+184
−297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10473 +/- ##
=======================================
Coverage ? 6.45%
=======================================
Files ? 1251
Lines ? 312681
Branches ? 0
=======================================
Hits ? 20196
Misses ? 292485
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…actor-rollout-key-ucs
…hyperswitch into refactor-rollout-key-ucs
2 tasks
| should_execute: false, | ||
| proxy_override: None, | ||
| execution_mode: ExecutionMode::NotApplicable, | ||
| } |
Contributor
There was a problem hiding this comment.
Can this be based on evaluation and then returning it ?
su-shivanshmathur
previously approved these changes
Dec 9, 2025
maverox
reviewed
Dec 9, 2025
| } | ||
|
|
||
| // Helper function to execute rollout logic or return default | ||
| fn execute_rollout_decision( |
Contributor
There was a problem hiding this comment.
can be converted into a From for RolloutExecutionResult;
the
is_valid_percent: bool,
is_valid_execution_mode: bool,
validations can be moved inside the from impl
maverox
approved these changes
Dec 9, 2025
maverox
reviewed
Dec 9, 2025
| "Using DirectConnector - not in ucs_only_list and rollout not enabled" | ||
| "Using DirectConnector - not in ucs_only_list" | ||
| ); | ||
| Ok(ConnectorIntegrationType::DirectConnector) |
Contributor
There was a problem hiding this comment.
Naming can be better as connectors that are in both hs and ucs are also grouped in DirectConnector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
There were two rollout keys in HS<>UCS tunnel which were creating confusion so I merged them So that the Transaction can be controlled using one rollout key.
Additional Changes
Motivation and Context
How did you test it?
This is curl for creating the config
Authorize Flow
Authorize Request
Authorize Response
{ "payment_id": "pay_nGxyofcByR45vSXqtxcw", "merchant_id": "merchant_1761124451", "status": "succeeded", "amount": 6540, "net_amount": 6540, "connector": "authorizedotnet", "client_secret": "pay_nGxyofcByR45vSXqtxcw_secret_uDqnVxhyI4Mvubh6tkak", "currency": "USD", "customer_id": "customer123w9ryuwuryweiuyrewiuhi", "description": "Its my first payment request", "capture_method": "automatic", "payment_method": "card", "connector_transaction_id": "120073086322", "network_transaction_id": "WC001WNXVWT1BHW7ICMFA44", "merchant_order_reference_id": "testing_the_integ03454", "connector_mandate_id": "933135702-932436342", "feature_metadata": { "gateway_system": "direct" }, "connector_metadata": { "noon": { "order_category": "pay" } }, "order_details": [ { "product_name": "Apple iphone 15", "quantity": 1, "amount": 6540 } ], "ephemeral_key": { "customer_id": "customer123w9ryuwuryweiuyrewiuhi", "created_at": 1761306340, "expires": 1761309940, "secret": "epk_5329d1ef7bfc4c21a17d689167caa98a" }, "whole_connector_response": "{\"transactionResponse\":{\"responseCode\":\"1\",\"authCode\":\"19RFGL\",\"avsResultCode\":\"Y\",\"cvvResultCode\":\"P\",\"transId\":\"120073086322\",\"messages\":[{\"code\":\"1\",\"description\":\"This transaction has been approved.\"}]}}" }Checklist
cargo +nightly fmt --allcargo clippy