Enable more clang-tidy checks

Author: tpoole

.clang-tidy

@@ -1,4 +1,5 @@
 Checks: >
+    clang-analyzer-*,
     -clang-analyzer-cplusplus.NewDeleteLeaks,
     -clang-analyzer-optin.performance.Padding,
     -clang-analyzer-security.FloatLoopCounter,

modules/juce_core/text/juce_String.cpp

@@ -1257,8 +1257,8 @@ String String::replaceSection (int index, int numCharsToReplace, StringRef strin
     if (numCharsToReplace < 0)
     {
         // replacing a negative number of characters?
-        numCharsToReplace = 0;
         jassertfalse;
+        numCharsToReplace = 0;
     }
 
     auto insertPoint = text;

modules/juce_gui_extra/misc/juce_WebControlRelays.cpp

@@ -129,7 +129,6 @@ void WebSliderRelay::handleEvent (const var& event)
         }
     }
 
-    const auto s = JSON::toString (event);
     jassertfalse;
 }
 
@@ -206,7 +205,6 @@ void WebToggleButtonRelay::handleEvent (const var& event)
         }
     }
 
-    const auto s = JSON::toString (event);
     jassertfalse;
 }
 
@@ -283,7 +281,6 @@ void WebComboBoxRelay::handleEvent (const var& event)
         }
     }
 
-    const auto s = JSON::toString (event);
     jassertfalse;
 }