[5.4] Modules run getLayoutData() twice

[Hackwar]

Steps to reproduce the issue

Create a popular tags module, enable debugging and go to a page that displays the module. See that the query to get the information of the popular tags is run twice.

The problem is, that Dispatcher::dispatch() of the module calls $this->getLayoutData(), which runs all the methods to get the data and when it then later calls parent::dispatch() the parent method calls that again. So we are running this unnecessarily twice.

[richard67]

Can this cause issue #46751 ?

[richard67]

P.S.: Especially this comment #46751 (comment) regarding the twice.

[Hackwar]

Nope, this isn't related.

[brianteeman]

confirmed

[Fedik]

Please specify in which module it happen.
I do not see it in mod_articles and mod_custom for example.

It is a bug in the module itself.

[brianteeman]

as stated it is the popular tags module

[Fedik]

Yes, just found, I had to read again, sorry 😄

[Fedik]

The method dispatch() in this module need to remove.

And this code need to be moved to getLayoutData()

joomla-cms/modules/mod_tags_popular/src/Dispatcher/Dispatcher.php

Lines 42 to 44 in 7c94640

	if (!\count($displayData['list']) && !$displayData['params']->get('no_results_text')) {
	return;
	}

Inside getLayoutData() it should return false to stop rendering.

[joomdonation]

Inside getLayoutData() it should return false to stop rendering.

PR, please :D.

[Fedik]

I leave it for Students 😄
"Good first fix"