Skip to content

Commit 71687b5

Browse files
author
iso2013
committed
Fix a silly bug resulting in unmount packets being cancelled.
1 parent edde72d commit 71687b5

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

API/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<artifactId>PacketEntityAPI</artifactId>
77
<groupId>net.blitzcube.peapi</groupId>
8-
<version>0.4.0-SNAPSHOT</version>
8+
<version>0.4.1-SNAPSHOT</version>
99
</parent>
1010
<modelVersion>4.0.0</modelVersion>
1111

Plugin/pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<artifactId>PacketEntityAPI</artifactId>
88
<groupId>net.blitzcube.peapi</groupId>
9-
<version>0.4.0-SNAPSHOT</version>
9+
<version>0.4.1-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>Plugin</artifactId>
@@ -59,7 +59,7 @@
5959
<dependency>
6060
<groupId>net.blitzcube.peapi</groupId>
6161
<artifactId>API</artifactId>
62-
<version>0.4.0-SNAPSHOT</version>
62+
<version>0.4.1-SNAPSHOT</version>
6363
</dependency>
6464
</dependencies>
6565
</project>

Plugin/src/main/java/net/blitzcube/peapi/event/engine/listeners/GenericListener.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@ public void onPacketSending(PacketEvent packetEvent) {
6969
IEntityPacketEvent e = new EntityPacketEvent(manager, w, eT, target);
7070
dispatcher.dispatch(e, null);
7171
if (e.getPacket() instanceof IEntityGroupPacket) {
72-
if (((IEntityGroupPacket) e.getPacket()).getGroup().size() == 0 || e.isCancelled()) {
72+
if ((e.getPacketType() == IEntityPacketEvent.EntityPacketType.DESTROY
73+
&& ((IEntityGroupPacket) e.getPacket()).getGroup().size() == 0) || e.isCancelled()) {
7374
packetEvent.setCancelled(true);
7475
return;
7576
}

Plugin/src/main/java/net/blitzcube/peapi/packet/ObjectSpawnPacket.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ public void setVelocity(Vector velocity) {
246246
type != EntityType.EXPERIENCE_ORB,
247247
"You cannot set a velocity for a " + type.name() + "!");
248248
this.velocity = velocity;
249-
//TODO: This is wrong.
249+
//FixMe: This implementation is not correct.
250250
super.rawPacket.getIntegers().write(1, (int) velocity.getX());
251251
super.rawPacket.getIntegers().write(2, (int) velocity.getY());
252252
super.rawPacket.getIntegers().write(3, (int) velocity.getZ());

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<groupId>net.blitzcube.peapi</groupId>
88
<artifactId>PacketEntityAPI</artifactId>
99
<packaging>pom</packaging>
10-
<version>0.4.0-SNAPSHOT</version>
10+
<version>0.4.1-SNAPSHOT</version>
1111
<modules>
1212
<module>API</module>
1313
<module>Plugin</module>

0 commit comments

Comments
 (0)