-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Labels
Description
Context
The DiscoveryTimeout field in ServerReconciler currently relies on wall-clock time (time.Second) in tests, which can lead to flaky behavior on slower CI runners. Tests should be deterministic and not depend on timing assumptions.
Location
- File:
internal/controller/suite_test.go - Field:
DiscoveryTimeout(Line 201) - Component:
ServerReconcilertest setup
Issue
The test configuration sets DiscoveryTimeout: time.Second which makes envtest behavior dependent on real wall-clock time. This violates the principle that tests should be deterministic.
Background
This issue was identified during review of PR #536, though it is a pre-existing concern not introduced by that PR.
- Related PR: Parameterisation of default discovery ignition #536
- Review comment: Parameterisation of default discovery ignition #536 (comment)
Reported by: @asergeant01
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
No status