Skip to content

Commit c21c717

Browse files
chore: included prerelease version in currency report (#1664)
1 parent 3598554 commit c21c717

3 files changed

Lines changed: 13 additions & 4 deletions

File tree

bin/currency/generate-currency-report.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,11 @@ currencies = currencies.map(currency => {
5050
installedVersion = installedVersion.replace(/[^0-9.]/g, '');
5151
}
5252

53-
latestVersion = utils.getLatestVersion(currency.name, installedVersion);
53+
latestVersion = utils.getLatestVersion({
54+
pkgName: currency.name,
55+
installedVersion: installedVersion,
56+
isBeta: currency.isBeta
57+
});
5458

5559
if (!installedVersion) {
5660
installedVersion = latestVersion;

bin/currency/update-currencies.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,11 @@ currencies.forEach(currency => {
7272
}
7373

7474
installedVersion = installedVersion.replace(/[^0-9.]/g, '');
75-
const latestVersion = utils.getLatestVersion(currency.name, installedVersion);
75+
const latestVersion = utils.getLatestVersion({
76+
pkgName: currency.name,
77+
installedVersion: installedVersion,
78+
isBeta: currency.isBeta
79+
});
7680

7781
if (latestVersion === installedVersion) {
7882
console.log(

bin/currency/utils.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ const getHighestMajorVersion = versions => {
9393
return highestMajorVersion;
9494
};
9595

96-
exports.getLatestVersion = (pkgName, installedVersion) => {
96+
exports.getLatestVersion = ({ pkgName, installedVersion, isBeta }) => {
9797
let latestVersion = execSync(`npm info ${pkgName} version`).toString().trim();
9898
const allVersions = getAllVersions(pkgName);
9999
const highestMajorVersion = getHighestMajorVersion(allVersions);
@@ -107,7 +107,8 @@ exports.getLatestVersion = (pkgName, installedVersion) => {
107107
`Detected a higher major version: ${highestMajorVersion} and this version is a prerelease: ${!!highestMajorVersionIsPrerelease}`
108108
);
109109

110-
if (!highestMajorVersionIsPrerelease) {
110+
// If isBeta is true, then we allow prerelease version as latest in currency report
111+
if (!highestMajorVersionIsPrerelease || isBeta) {
111112
latestVersion = highestMajorVersion;
112113
}
113114
}

0 commit comments

Comments
 (0)