Patched DF 50.3.0 (revision c) #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rceDistribution) which later causes an error during EnforceSort (without our patch). The next DataFusion version 46 upgrade does the proper fix, which is to not insert the coalesce in the first place. test: recreating the iox plan: * demonstrate the insertion of coalesce after the use of column estimates, and the removal of the test scenario's forcing of rr repartitioning test: reproducer of SanityCheck failure after EnforceSorting removes the coalesce added in the EnforceDistribution fix: special case to not remove the needed coalesce
erratic-pattern
changed the title
* test: reproducer of bug * fix: make schema names unique for approx_percentile_cont * test: regression test is now resolved
erratic-pattern
force-pushed
the
upgrade-df-ver5030-c
branch
from
ae92c52 to
9302b5a
Compare
Collaborator
|
Superceded by #81 |
Collaborator
|
The CI is failing due to what looks like out of disk space I think this is due to a change in what is pre-installed on github runners (bloatware!). We fixed this upstream with a fix here: I'll cherry-pick that commit to this branch and hopefully get a clean run |
…8709) Closes apache#18692 (hopefully) Trying to get CI to pass consistently, try various techniques.
Collaborator
|
CI is green 🎉 |
Author
|
Whoops I accidentally merged this. I force-pushed base-df-upgrade-ver5030 to revert it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from revision b:
Rust / cargo test (amd64)action apache/datafusion#18709 to get a clean CI runRationale: https://github.com/influxdata/influxdb_iox/issues/15534#issuecomment-3602490365 (aka don't spam logs in influxdb_pro: https://github.com/influxdata/influxdb_pro/issues/1788)