Tcp: add TODO to replace bool return with void + getFsmState() check

The process methods (processAppCommand, processTCPSegment,
processIcmpv4Error, processIcmpv6Error) currently return bool to signal
whether the connection moved to CLOSED. This could be simplified by
making them void and having the Tcp module check
conn->getFsmState() == TCP_S_CLOSED after each call instead.

Author: ZoltanBojthe

src/inet/transportlayer/tcp/Tcp.cc

@@ -104,6 +104,8 @@ void Tcp::handleUpperCommand(cMessage *msg)
         EV_INFO << "Tcp connection created for " << msg << "\n";
     }
 
+    // TODO replace bool return convention with void + conn->getFsmState() == TCP_S_CLOSED check
+    // (applies to processAppCommand, processTCPSegment, processIcmpv4Error, processIcmpv6Error)
     if (!conn->processAppCommand(msg))
         removeConnection(conn);
 }