Skip to content

API calls to /machine are deprecated; use /node #128

@l00ps

Description

@l00ps

When running headscale-webui against headscale v0.22.3, multiple pages don't load:

Trace:

Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]:   File "/home/ubuntu/src/headscale-webui/server.py", line 114, in decorated
Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]:     return view_func(*args, **kwargs)
Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^
Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]:   File "/home/ubuntu/src/headscale-webui/server.py", line 207, in machines_page
Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]:     cards = renderer.render_machines_cards()
Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]:             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]:   File "/home/ubuntu/src/headscale-webui/renderer.py", line 490, in render_machines_cards
Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]:     num_threads = len(machines_list["machines"])
Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]:                       ~~~~~~~~~~~~~^^^^^^^^^^^^
Dec 17 17:19:49 ip-172-31-86-15 poetry[35992]: KeyError: 'machines'

Cause:
Upon inspection of the headscale API, the correct endpoint is api/v1/node, and it returns a list named nodes. renderer.py currently calls api/v1/machine and expects a response containing a list called machines.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions