Skip to content

Commit 7eca8a8

Browse files
committed
Finish test of issue API-228
1 parent 029c91c commit 7eca8a8

File tree

1 file changed

+31
-13
lines changed

1 file changed

+31
-13
lines changed

tests/Issues/API228Test.php

Lines changed: 31 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -130,22 +130,21 @@ public function testSave() {
130130
);
131131

132132
$this->assertIsArray($entries);
133-
$this->validateEntries($entries, $vhostID, $licenseHostID, $serviceID);
133+
$this->validateEntries($entries, $vhostID, $licenseHostID, $vmID, $appID);
134134

135135
/**
136136
* Update entry:
137137
*/
138138

139-
$sameEntryID = $this->useCMDBCategory()->save(
139+
$this->useCMDBCategory()->save(
140140
$vhostID,
141141
Category::CATG__VIRTUAL_HOST,
142142
[
143143
'description' => $this->generateDescription()
144-
]
144+
],
145+
$entryID
145146
);
146147

147-
$this->assertSame($entryID, $sameEntryID);
148-
149148
/**
150149
* Run tests again:
151150
*/
@@ -156,7 +155,7 @@ public function testSave() {
156155
);
157156

158157
$this->assertIsArray($entries);
159-
$this->validateEntries($entries, $vhostID, $licenseHostID, $serviceID);
158+
$this->validateEntries($entries, $vhostID, $licenseHostID, $vmID, $appID);
160159
}
161160

162161
/**
@@ -250,7 +249,7 @@ public function testUpdate() {
250249
);
251250

252251
$this->assertIsArray($entries);
253-
$this->validateEntries($entries, $vhostID, $licenseHostID, $serviceID);
252+
$this->validateEntries($entries, $vhostID, $licenseHostID, $vmID, $appID);
254253

255254
/**
256255
* Update entry:
@@ -261,7 +260,8 @@ public function testUpdate() {
261260
Category::CATG__VIRTUAL_HOST,
262261
[
263262
'description' => $this->generateDescription()
264-
]
263+
],
264+
$entryID
265265
);
266266

267267
/**
@@ -274,10 +274,10 @@ public function testUpdate() {
274274
);
275275

276276
$this->assertIsArray($entries);
277-
$this->validateEntries($entries, $vhostID, $licenseHostID, $serviceID);
277+
$this->validateEntries($entries, $vhostID, $licenseHostID, $vmID, $appID);
278278
}
279279

280-
protected function validateEntries(array $entries, int $vhostID, int $licenseHostID, $serviceID) {
280+
protected function validateEntries(array $entries, int $vhostID, int $licenseHostID, $vmID, $appID) {
281281
$this->assertCount(1, $entries);
282282
$this->assertArrayHasKey(0, $entries);
283283
$this->assertIsArray($entries[0]);
@@ -298,9 +298,27 @@ protected function validateEntries(array $entries, int $vhostID, int $licenseHos
298298

299299
$this->assertArrayHasKey('administration_service', $entries[0]);
300300
$this->assertIsArray($entries[0]['administration_service']);
301-
302-
// @todo Implement proper tests!
303-
$this->assertIsInt($serviceID);
301+
$this->assertCount(3, $entries[0]['administration_service']);
302+
303+
$this->assertArrayHasKey(0, $entries[0]['administration_service']);
304+
$this->assertIsArray($entries[0]['administration_service'][0]);
305+
$this->assertArrayHasKey('id', $entries[0]['administration_service'][0]);
306+
$this->assertSame($vmID, (int) $entries[0]['administration_service'][0]['id']);
307+
$this->assertArrayHasKey('type', $entries[0]['administration_service'][0]);
308+
$this->assertSame(ObjectType::VIRTUAL_SERVER, $entries[0]['administration_service'][0]['type']);
309+
310+
$this->assertArrayHasKey(1, $entries[0]['administration_service']);
311+
$this->assertIsArray($entries[0]['administration_service'][1]);
312+
$this->assertArrayHasKey('id', $entries[0]['administration_service'][1]);
313+
$this->assertSame($appID, (int) $entries[0]['administration_service'][1]['id']);
314+
$this->assertArrayHasKey('type', $entries[0]['administration_service'][1]);
315+
$this->assertSame(ObjectType::APPLICATION, $entries[0]['administration_service'][1]['type']);
316+
317+
$this->assertArrayHasKey(2, $entries[0]['administration_service']);
318+
$this->assertIsArray($entries[0]['administration_service'][2]);
319+
$this->assertArrayHasKey('id', $entries[0]['administration_service'][2]);
320+
$this->assertArrayHasKey('title_lang', $entries[0]['administration_service'][2]);
321+
$this->assertSame('LC__CMDB__CATG__APPLICATION', $entries[0]['administration_service'][2]['title_lang']);
304322
}
305323

306324
}

0 commit comments

Comments
 (0)