Skip to content

Commit 2178086

Browse files
rollback userUrl addition in status method. reflect changes to dapp-api specs in extension
Signed-off-by: Pawel Stepien <[email protected]>
1 parent 66d9b87 commit 2178086

File tree

12 files changed

+21
-35
lines changed

12 files changed

+21
-35
lines changed

api-specs/openrpc-dapp-api.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -578,12 +578,7 @@
578578
"required": ["accessToken", "userId"]
579579
}
580580
},
581-
"required": [
582-
"kernel",
583-
"isConnected",
584-
"isNetworkConnected",
585-
"userUrl"
586-
]
581+
"required": ["kernel", "isConnected", "isNetworkConnected"]
587582
}
588583
}
589584
}

api-specs/openrpc-dapp-remote-api.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -607,12 +607,7 @@
607607
"required": ["accessToken", "userId"]
608608
}
609609
},
610-
"required": [
611-
"kernel",
612-
"isConnected",
613-
"isNetworkConnected",
614-
"userUrl"
615-
]
610+
"required": ["kernel", "isConnected", "isNetworkConnected"]
616611
}
617612
}
618613
}

core/wallet-dapp-remote-rpc-client/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ export interface StatusEvent {
198198
isConnected: IsConnected
199199
isNetworkConnected: IsNetworkConnected
200200
networkReason?: NetworkReason
201-
userUrl: UserUrl
201+
userUrl?: UserUrl
202202
network?: Network
203203
session?: Session
204204
[k: string]: any

core/wallet-dapp-remote-rpc-client/src/openrpc.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -607,12 +607,7 @@
607607
"required": ["accessToken", "userId"]
608608
}
609609
},
610-
"required": [
611-
"kernel",
612-
"isConnected",
613-
"isNetworkConnected",
614-
"userUrl"
615-
]
610+
"required": ["kernel", "isConnected", "isNetworkConnected"]
616611
}
617612
}
618613
}

core/wallet-dapp-rpc-client/src/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export interface StatusEvent {
199199
isConnected: IsConnected
200200
isNetworkConnected: IsNetworkConnected
201201
networkReason?: NetworkReason
202-
userUrl: UserUrl
202+
userUrl?: UserUrl
203203
network?: Network
204204
session?: Session
205205
[k: string]: any

core/wallet-dapp-rpc-client/src/openrpc.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -578,12 +578,7 @@
578578
"required": ["accessToken", "userId"]
579579
}
580580
},
581-
"required": [
582-
"kernel",
583-
"isConnected",
584-
"isNetworkConnected",
585-
"userUrl"
586-
]
581+
"required": ["kernel", "isConnected", "isNetworkConnected"]
587582
}
588583
}
589584
}

sdk/dapp-sdk/src/dapp-api/rpc-gen/typings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export interface StatusEvent {
199199
isConnected: IsConnected
200200
isNetworkConnected: IsNetworkConnected
201201
networkReason?: NetworkReason
202-
userUrl: UserUrl
202+
userUrl?: UserUrl
203203
network?: Network
204204
session?: Session
205205
[k: string]: any

sdk/dapp-sdk/src/provider.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ export const dappController = (provider: SpliceProvider) =>
163163
})
164164

165165
if (!response.status.isConnected)
166-
openKernelUserUI('remote', response.status.userUrl)
166+
openKernelUserUI('remote', response.status.userUrl ?? '')
167167

168168
const promise = new Promise<dappAPI.ConnectResult>(
169169
(resolve, reject) => {
@@ -207,8 +207,7 @@ export const dappController = (provider: SpliceProvider) =>
207207
params,
208208
})
209209

210-
if (!response.isConnected)
211-
openKernelUserUI('remote', response.userUrl)
210+
if (response.userUrl) openKernelUserUI('remote', response.userUrl)
212211

213212
const promise = new Promise<dappAPI.PrepareExecuteResult>(
214213
(resolve, reject) => {

wallet-gateway/extension/src/dapp-api/controller.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,17 @@ export const dappController = (store?: Store) =>
3030
isConnected: false,
3131
isNetworkConnected: false,
3232
networkReason: 'Unauthenticated',
33-
networkId: 'default-network-id',
3433
userUrl: Browser.runtime.getURL('pages/user.html'),
34+
network: {
35+
networkId: 'default-network-id',
36+
ledgerApi: {
37+
baseUrl: 'http://default-ledger-api',
38+
},
39+
},
40+
session: {
41+
accessToken: 'default-access-token',
42+
userId: 'default-user-id',
43+
},
3544
},
3645
sessionToken: 'default-session-token',
3746
}),

wallet-gateway/extension/src/dapp-api/rpc-gen/typings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export interface StatusEvent {
199199
isConnected: IsConnected
200200
isNetworkConnected: IsNetworkConnected
201201
networkReason?: NetworkReason
202-
userUrl: UserUrl
202+
userUrl?: UserUrl
203203
network?: Network
204204
session?: Session
205205
[k: string]: any

0 commit comments

Comments
 (0)