L5X export: Controller element is missing most attributes (Name, ProcessorType, MajorRev, etc.)

[cmwarre]

Description

The <Controller> element in the exported L5X is missing the majority of its standard attributes. A Logix Designer export includes ~20 attributes; the library currently emits only 7, all of them non-essential.

Comparison

Generated by library:

<Controller SerialNumber="16#60E3_5B29" CommPath="" SfcExecutionControl="CurrentActive"
            SfcRestartPosition="MostRecent" SfcLastScan="DontScan"
            CreatedDate="..." ModifiedDate="...">

Expected (Logix Designer export):

<Controller Use="Target" Name="CIPDemo" ProcessorType="1756-L83E"
            MajorRev="35" MinorRev="11" MajorFaultProgram="Fault_Recovery"
            ProjectCreationDate="..." LastModifiedDate="..."
            SFCExecutionControl="CurrentActive" SFCRestartPosition="MostRecent"
            SFCLastScan="DontScan" ProjectSN="16#60e3_5b29"
            MatchProjectToController="false" CanUseRPIFromProducer="false"
            InhibitAutomaticFirmwareUpdate="0"
            PassThroughConfiguration="EnabledWithAppend"
            DownloadProjectDocumentationAndExtendedProperties="true"
            DownloadProjectCustomProperties="true"
            ReportMinorOverflow="false" AutoDiagsEnabled="false"
            WebServerEnabled="false">

Key Missing Attributes

Attribute	Example Value	Notes
Use	Target	Required for import
Name	CIPDemo	Controller name
ProcessorType	1756-L83E	Hardware model
MajorRev / MinorRev	35 / 11	Firmware revision
MajorFaultProgram	Fault_Recovery
ProjectSN	16#60e3_5b29	Project serial number

The data for most of these is available in QuickInfo.XML inside the ACD archive.

[jpect]

Fixed in commit fb79240 on the jpect/acd fork. A follow-up PR will be submitted once the initial PR #18 is reviewed.