Skip to content

Commit c2e44e6

Browse files
committed
resolve TODO comments in the containerOverrides for Branded content & use inherit rather than a named variable colour
1 parent 4f48f18 commit c2e44e6

File tree

2 files changed

+11
-36
lines changed

2 files changed

+11
-36
lines changed

dotcom-rendering/src/components/ContainerOverrides.tsx

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,8 @@ const cardHeadlineLight: ContainerFunction = (
2828
return sourcePalette.neutral[93];
2929
case 'SpecialReportAltPalette':
3030
return sourcePalette.specialReportAlt[100];
31-
// TODO: @commercial-dev to update to neutral[7] when launching Redesigned Labs Containers
3231
case 'Branded':
33-
return sourcePalette.neutral[20];
32+
return 'inherit';
3433
}
3534
};
3635
const cardHeadlineDark: ContainerFunction = (
@@ -83,8 +82,7 @@ const cardTrailTextLight: ContainerFunction = (
8382
case 'SpecialReportAltPalette':
8483
return sourcePalette.specialReportAlt[100];
8584
case 'Branded':
86-
// TODO: @commercial-dev to update to palette('--card-trail-text') when launching Redesigned Labs Containers
87-
return sourcePalette.neutral[20];
85+
return 'inherit';
8886
}
8987
};
9088
const cardTrailTextDark: ContainerFunction = (
@@ -110,8 +108,7 @@ const cardTrailTextDark: ContainerFunction = (
110108
case 'SpecialReportAltPalette':
111109
return sourcePalette.specialReportAlt[700];
112110
case 'Branded':
113-
// TODO: @commercial-dev to update to palette('--card-trail-text') when launching Redesigned Labs Containers
114-
return sourcePalette.neutral[86];
111+
return 'inherit';
115112
}
116113
};
117114

@@ -136,8 +133,7 @@ const cardKickerTextLight: ContainerFunction = (containerPalette) => {
136133
case 'SpecialReportAltPalette':
137134
return sourcePalette.specialReportAlt[100];
138135
case 'Branded':
139-
// TODO: @commercial-dev to update to labs[100] when launching Redesigned Labs Containers
140-
return sourcePalette.labs[200];
136+
return sourcePalette.labs[100];
141137
}
142138
};
143139
const cardKickerTextDark: ContainerFunction = (containerPalette) => {
@@ -186,8 +182,7 @@ const cardQuoteIconLight: ContainerFunction = (containerPalette) => {
186182
case 'SpecialReportAltPalette':
187183
return sourcePalette.specialReportAlt[100];
188184
case 'Branded':
189-
// TODO: @commercial-dev to update to labs[100] when launching Redesigned Labs Containers
190-
return sourcePalette.labs[200];
185+
return sourcePalette.labs[100];
191186
}
192187
};
193188
const cardQuoteIconDark: ContainerFunction = (containerPalette) => {
@@ -583,8 +578,7 @@ const cardMediaWaveformLight: ContainerFunction = (containerPalette) => {
583578
case 'SpecialReportAltPalette':
584579
return sourcePalette.specialReportAlt[800];
585580
case 'Branded':
586-
// TODO: @commercial-dev to update to palette('--card-media-waveform') when launching Redesigned Labs Containers
587-
return sourcePalette.neutral[86];
581+
return 'inherit';
588582
}
589583
};
590584

@@ -604,8 +598,7 @@ const cardMediaWaveformDark: ContainerFunction = (containerPalette) => {
604598
case 'EventAltPalette':
605599
return sourcePalette.culture[300];
606600
case 'Branded':
607-
// TODO: @commercial-dev to update to palette('--card-media-waveform') when launching Redesigned Labs Containers
608-
return sourcePalette.neutral[38];
601+
return 'inherit';
609602
}
610603
};
611604

@@ -630,7 +623,7 @@ const sectionBackgroundLight: ContainerFunction = (containerPalette) => {
630623
case 'SpecialReportAltPalette':
631624
return sourcePalette.specialReportAlt[800];
632625
case 'Branded':
633-
return palette('--section-background');
626+
return 'inherit';
634627
}
635628
};
636629

@@ -654,7 +647,7 @@ const sectionBackgroundDark: ContainerFunction = (containerPalette) => {
654647
case 'SpecialReportAltPalette':
655648
return sourcePalette.specialReportAlt[100];
656649
case 'Branded':
657-
return palette('--section-background');
650+
return 'inherit';
658651
}
659652
};
660653

@@ -712,8 +705,7 @@ const cardBorderSupportingLight: ContainerFunction = (containerPalette) => {
712705
case 'SpecialReportAltPalette':
713706
return transparentColour(sourcePalette.neutral[46], 0.3);
714707
case 'Branded':
715-
// TODO: @commercial-dev to update to palette('--card-border-supporting') when launching Redesigned Labs Containers
716-
return sourcePalette.neutral[73];
708+
return 'inherit';
717709
}
718710
};
719711
const cardBorderSupportingDark: ContainerFunction = (containerPalette) => {
@@ -735,8 +727,7 @@ const cardBorderSupportingDark: ContainerFunction = (containerPalette) => {
735727
case 'SpecialReportAltPalette':
736728
return transparentColour(sourcePalette.neutral[46], 0.3);
737729
case 'Branded':
738-
// TODO: @commercial-dev to update to palette('--card-border-supporting') when launching Redesigned Labs Containers
739-
return sourcePalette.neutral[46];
730+
return 'inherit';
740731
}
741732
};
742733

dotcom-rendering/src/paletteDeclarations.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7421,22 +7421,6 @@ const paletteColours = {
74217421
light: () => sourcePalette.neutral[0],
74227422
dark: () => sourcePalette.neutral[100],
74237423
},
7424-
'--labs-legacy-article-section-title': {
7425-
light: () => sourcePalette.neutral[100],
7426-
dark: () => sourcePalette.neutral[97],
7427-
},
7428-
'--labs-legacy-section-background': {
7429-
light: () => sourcePalette.neutral[93],
7430-
dark: () => sourcePalette.neutral[20],
7431-
},
7432-
'--labs-legacy-section-background-left': {
7433-
light: () => sourcePalette.labs[400],
7434-
dark: () => sourcePalette.labs[200],
7435-
},
7436-
'--labs-legacy-treat-text': {
7437-
light: () => sourcePalette.neutral[46],
7438-
dark: () => sourcePalette.neutral[38],
7439-
},
74407424
'--labs-logo-background': {
74417425
light: () => sourcePalette.labs[100],
74427426
dark: () => sourcePalette.labs[200],

0 commit comments

Comments
 (0)