prudynt does not respect ROI's

[theahadev]

prudynt only uses the first ROI, the other ROI's are not used.

Default config:

  roi_0_x = 0;
  roi_0_y = 0;
  roi_1_x = 639;
  roi_1_y = 359;
  roi_count = 1;
};
rois : 
{
  roi_0 = [ 0, 0, 0, 0 ];
};

Expected behaviour:
motion script gets triggered
Real behaviour:
motion script gets triggered

The config i tried:

  roi_0_x = 320;
  roi_0_y = 180;
  roi_1_x = 639;
  roi_1_y = 359; #this is an inactive area, there is no movement here
  roi_count = 1; #increasing this also makes no difference
};
rois : 
{
  roi_0 = [ 0, 0, 319, 179 ]; #a very active area
};

Expected behaviour:
motion script gets triggered
Real behaviour:
motion script doesn't get triggered

[matiasdelellis]

Hi,
It seems not.. I was just trying to implement it, and I didn't know how to add the configuration. Just looking at your ticket, I discovered that the configuration is already in place, but it's not being taken into account.

Configuration is implemented since 54e8e69
But it only adds the default ROI (and the only documented option) to motion detection. See

prudynt-t/src/Motion.cpp

Lines 174 to 185 in 57fd23f

	LOG_INFO("Motion detection:" <<
	" sensibility: " << move_param.sense[0] <<
	", skipCnt:" << move_param.skipFrameCnt <<
	", width:" << move_param.frameInfo.width <<
	", height:" << move_param.frameInfo.height);
	move_param.roiRect[0].p0.x = cfg->motion.roi_0_x;
	move_param.roiRect[0].p0.y = cfg->motion.roi_0_y;
	move_param.roiRect[0].p1.x = cfg->motion.roi_1_x - 1;
	move_param.roiRect[0].p1.y = cfg->motion.roi_1_y - 1;
	move_param.roiRectCnt = cfg->motion.roi_count;

@gtxaspec First of all, sorry for tagging you, but probably with just this patch it would work.

diff --git a/src/Motion.cpp b/src/Motion.cpp
index bcdbf3d..1623b40 100644
--- a/src/Motion.cpp
+++ b/src/Motion.cpp
@@ -128,6 +128,8 @@ void Motion::detect()
 
 int Motion::init()
 {
+    int i = 0;
+
     LOG_INFO("Initialize motion detection.");
 
     if((cfg->motion.monitor_stream == 0 && !cfg->stream0.enabled) || 
@@ -160,7 +162,7 @@ int Motion::init()
         if (cfg->motion.roi_1_y == IVS_AUTO_VALUE)
         {
             cfg->set<int>(getConfigPath("roi_1_y"), channelAttributes.encAttr.picHeight - 1, true);
-        }        
+        } 
     }
 
     memset(&move_param, 0, sizeof(IMP_IVS_MoveParam));
@@ -177,17 +179,20 @@ int Motion::init()
              ", width:" << move_param.frameInfo.width << 
              ", height:" << move_param.frameInfo.height);
 
-    move_param.roiRect[0].p0.x = cfg->motion.roi_0_x;
-    move_param.roiRect[0].p0.y = cfg->motion.roi_0_y;
-    move_param.roiRect[0].p1.x = cfg->motion.roi_1_x - 1;
-    move_param.roiRect[0].p1.y = cfg->motion.roi_1_y - 1;
-    move_param.roiRectCnt = cfg->motion.roi_count;
+    for (i = 0; i < cfg->motion.roi_count; i++) {
+        move_param.roiRect[i].p0.x = cfg->motion.rois[i].p0_x;
+        move_param.roiRect[i].p0.y = cfg->motion.rois[i].p0_y;
+        move_param.roiRect[i].p1.x = cfg->motion.rois[i].p1_x;
+        move_param.roiRect[i].p1.y = cfg->motion.rois[i].p1_y;
+
+        LOG_INFO("Motion detection roi[" << i << "]:" <<
+                 " roi_0_x: " << cfg->motion.rois[i].p0_x <<
+                 ", roi_0_y:" << cfg->motion.rois[i].p0_y <<
+                 ", roi_1_x: " << cfg->motion.rois[i].p1_x <<
+                 ", roi_1_y:" << cfg->motion.rois[i].p1_y);
+    }
 
-    LOG_INFO("Motion detection roi[0]:" << 
-             " roi_0_x: " << cfg->motion.roi_0_x << 
-             ", roi_0_y:" << cfg->motion.roi_0_y << 
-             ", roi_1_x: " << cfg->motion.roi_1_x << 
-             ", roi_1_y:" << cfg->motion.roi_1_y);
+    move_param.roiRectCnt = cfg->motion.roi_count;
 
     move_intf = IMP_IVS_CreateMoveInterface(&move_param);

I just tested it to make sure it compiled correctly. But if you're interested, I can make a PR and test it further.

[matiasdelellis]

Well, I copied the compiled service to a camera, add a grid of regions, and it seems like it might work.

prudynt.cfg

  roi_count = 4;
};
rois :.
{
  roi_0 = [ 0, 0, 310, 160 ];
  roi_1 = [ 310, 0, 639, 160 ];
  roi_2 = [ 0, 160, 310, 359 ];
  roi_3 = [ 310, 160, 639, 359 ];
};

Service:

root@calle ~# /opt/prudynt-T31-dynamic 
[INFO:Config.cpp]: Loaded configuration from /etc/prudynt.cfg
[INFO:main.cpp]: PRUDYNT-T Next-Gen Video Daemon: Aug  7 2025 18:33:14_57fd23f
[INFO:main.cpp]: Starting Prudynt Video Server.
[INFO:IMPSystem.cpp]: LIBIMP Version IMP-1.1.6
[INFO:IMPSystem.cpp]: SYSUTILS Version: SYSUTILS-1.1.6
[INFO:IMPSystem.cpp]: CPU Information: T31-X
[INFO:IMPSystem.cpp]: Sensor: gc2053
---- FPGA board is ready ----
  Board UID : 30AB6E51
  Board HW ID : 72000460
  Board rev.  : 5DE5A975
  Board date  : 20190326
-----------------------------
[INFO:Opus.cpp]: Encoder bitrate: 40000
[ERROR:WS.cpp]: lws init failed
[INFO:WS.cpp]: Server started on port 8089
warn: shm_init,53shm init already
[INFO:IMPAudio.cpp]: Audio In: format:OPUS, vol:80, gain:25, samplerate:16000, bitwidth:16, soundmode:1, frmNum:30, numPerFrm:640, chnCnt:1, usrFrmDepth:30
set jpeg streamMngCtx suceess
[INFO:Motion.cpp]: Start motion detection thread.
[INFO:Motion.cpp]: Initialize motion detection.
[INFO:Motion.cpp]: Motion detection: sensibility: 2, skipCnt:5, width:640, height:360
[INFO:Motion.cpp]: Motion detection roi[0]: roi_0_x: 0, roi_0_y:0, roi_1_x: 310, roi_1_y:160
[INFO:Motion.cpp]: Motion detection roi[1]: roi_0_x: 310, roi_0_y:0, roi_1_x: 639, roi_1_y:160
[INFO:Motion.cpp]: Motion detection roi[2]: roi_0_x: 0, roi_0_y:160, roi_1_x: 310, roi_1_y:359
[INFO:Motion.cpp]: Motion detection roi[3]: roi_0_x: 310, roi_0_y:160, roi_1_x: 639, roi_1_y:359
[INFO:IMPAudioServerMediaSubsession.cpp]: IMPAudioServerMediaSubsession init
[INFO:RTSP.cpp]: Audio stream 0 added to session
[INFO:RTSP.cpp]: stream 0 available at: rtsp://192.168.1.93/ch0
[INFO:IMPAudioServerMediaSubsession.cpp]: IMPAudioServerMediaSubsession init
[INFO:RTSP.cpp]: Audio stream 1 added to session
[INFO:RTSP.cpp]: stream 1 available at: rtsp://192.168.1.93/ch1
[INFO:Motion.cpp]: Active motion detected in region 3
[INFO:Motion.cpp]: Motion Start
- Start motion
- Set /run/motion/motion_alarm
- Send alert to Ntfy
[INFO:Motion.cpp]: End of Motion
- Stop motion
- Remove /run/motion/motion_alarm

But it always reports in the last region... It could just be the camera position, but I need to check it out.. 😅

[theahadev]

Thank you for your efforts!
Though i would like to specify that i already switched the camera location to somewhere where it only sees where it needs to see. This fix probably won't benefit me right now, but maybe it will benefit other people, who knows?