[Wails] M5: Address UpdateService PR review feedback

- Fix Check() doc comment: StartAutoCheck → RunAutoCheck (flows through
  to the regenerated TS binding)
- Add User-Agent header to GitHub Releases API requests (GitHub API
  requires one for every request)
- Drain response body before Close so the TCP connection can be reused
- Drop dead Draft/Prerelease filter; /releases/latest already excludes
  both by definition
- Wrap table-driven test cases in t.Run for named subtests
- Swap Download icon → ExternalLink in UpdateBanner to match the
  behaviour (opens the release page in the external browser)

Co-Authored-By: Claude Opus 4.7 <[email protected]>

Author: josh-padnick

services/update_service.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	"io"
 	"log/slog"
 	"net/http"
 	"strings"
@@ -84,7 +85,7 @@ const (
 // Check performs a single release lookup and returns the result. Safe
 // to call from the frontend (e.g. a "Check for updates" menu item in
 // a future milestone); does not emit the `update:available` event —
-// callers that want the banner behaviour should use StartAutoCheck.
+// callers that want the banner behaviour should use RunAutoCheck.
 func (s *UpdateService) Check(ctx context.Context) (*UpdateInfo, error) {
 	return s.check(ctx)
 }
@@ -166,12 +167,17 @@ func (s *UpdateService) check(ctx context.Context) (*UpdateInfo, error) {
 	}
 	req.Header.Set("Accept", "application/vnd.github+json")
 	req.Header.Set("X-GitHub-Api-Version", "2022-11-28")
+	req.Header.Set("User-Agent", fmt.Sprintf("gruntbooks/%s", s.currentVersion))
 
 	resp, err := s.httpClient.Do(req)
 	if err != nil {
 		return nil, fmt.Errorf("fetch latest release: %w", err)
 	}
-	defer func() { _ = resp.Body.Close() }()
+	defer func() {
+		// Drain the body so the underlying TCP connection is reusable.
+		_, _ = io.Copy(io.Discard, resp.Body)
+		_ = resp.Body.Close()
+	}()
 
 	if resp.StatusCode == http.StatusNotFound {
 		return &UpdateInfo{
@@ -187,14 +193,8 @@ func (s *UpdateService) check(ctx context.Context) (*UpdateInfo, error) {
 	if err := json.NewDecoder(resp.Body).Decode(&release); err != nil {
 		return nil, fmt.Errorf("decode release: %w", err)
 	}
-	if release.Draft || release.Prerelease {
-		return &UpdateInfo{
-			Available:      false,
-			CurrentVersion: s.currentVersion,
-			LatestVersion:  release.TagName,
-			ReleaseURL:     release.HTMLURL,
-		}, nil
-	}
+	// GitHub's /releases/latest endpoint excludes drafts and prereleases
+	// by definition, so release.Draft/Prerelease filtering is unnecessary.
 
 	currentCanonical := normalizeSemver(s.currentVersion)
 	latestCanonical := normalizeSemver(release.TagName)

services/update_service_test.go

@@ -21,9 +21,11 @@ func TestNormalizeSemver(t *testing.T) {
 		{"not-a-version", ""},
 	}
 	for _, c := range cases {
-		if got := normalizeSemver(c.in); got != c.want {
-			t.Errorf("normalizeSemver(%q) = %q, want %q", c.in, got, c.want)
-		}
+		t.Run(c.in, func(t *testing.T) {
+			if got := normalizeSemver(c.in); got != c.want {
+				t.Errorf("normalizeSemver(%q) = %q, want %q", c.in, got, c.want)
+			}
+		})
 	}
 }
 
@@ -39,9 +41,11 @@ func TestIsReleaseVersion(t *testing.T) {
 		{"unknown", false},
 	}
 	for _, c := range cases {
-		s := NewUpdateService(adapters.NewNoopEmitter(), c.version)
-		if got := s.isReleaseVersion(); got != c.want {
-			t.Errorf("isReleaseVersion(%q) = %v, want %v", c.version, got, c.want)
-		}
+		t.Run(c.version, func(t *testing.T) {
+			s := NewUpdateService(adapters.NewNoopEmitter(), c.version)
+			if got := s.isReleaseVersion(); got != c.want {
+				t.Errorf("isReleaseVersion(%q) = %v, want %v", c.version, got, c.want)
+			}
+		})
 	}
 }

web/src/bindings/github.com/gruntwork-io/runbooks/services/updateservice.ts

@@ -30,7 +30,7 @@ import * as $models from "./models.js";
  * Check performs a single release lookup and returns the result. Safe
  * to call from the frontend (e.g. a "Check for updates" menu item in
  * a future milestone); does not emit the `update:available` event —
- * callers that want the banner behaviour should use StartAutoCheck.
+ * callers that want the banner behaviour should use RunAutoCheck.
  */
 export function Check(): $CancellablePromise<$models.UpdateInfo | null> {
     return $Call.ByID(374472365).then(($result: any) => {

web/src/components/UpdateBanner.tsx

@@ -1,6 +1,6 @@
 import { useEffect, useState } from 'react'
 import { Browser, Events } from '@wailsio/runtime'
-import { Download, X } from 'lucide-react'
+import { ExternalLink, X } from 'lucide-react'
 import type { UpdateInfo } from '../bindings/github.com/gruntwork-io/runbooks/services/models'
 import { isDesktop } from '../lib/wails'
 
@@ -61,7 +61,7 @@ export function UpdateBanner() {
           onClick={handleDownload}
           className="inline-flex items-center gap-1.5 rounded-md bg-primary px-3 py-1 text-primary-foreground hover:opacity-90 cursor-pointer"
         >
-          <Download className="h-3.5 w-3.5" />
+          <ExternalLink className="h-3.5 w-3.5" />
           Download
         </button>
         <button