chore: update tests for float

Author: olavloite

test/mockserver_tests/test_bit_reversed_sequence.py

@@ -21,7 +21,6 @@
     BatchCreateSessionsRequest,
     ExecuteSqlRequest,
     CommitRequest,
-    GetSessionRequest,
     BeginTransactionRequest,
 )
 from test.mockserver_tests.mock_server_test_base import (
@@ -128,10 +127,8 @@ def test_insert_row(self):
             session.commit()
         # Verify the requests that we got.
         requests = self.spanner_service.requests
-        eq_(5, len(requests))
+        eq_(4, len(requests))
         is_instance_of(requests[0], BatchCreateSessionsRequest)
-        # We should get rid of this extra round-trip for GetSession....
-        is_instance_of(requests[1], GetSessionRequest)
-        is_instance_of(requests[2], BeginTransactionRequest)
-        is_instance_of(requests[3], ExecuteSqlRequest)
-        is_instance_of(requests[4], CommitRequest)
+        is_instance_of(requests[1], BeginTransactionRequest)
+        is_instance_of(requests[2], ExecuteSqlRequest)
+        is_instance_of(requests[3], CommitRequest)

test/test_suite_13.py

@@ -27,7 +27,7 @@
 from google.cloud.spanner_v1 import RequestOptions, Client
 
 import sqlalchemy
-from sqlalchemy import create_engine
+from sqlalchemy import create_engine, literal, FLOAT
 from sqlalchemy import inspect
 from sqlalchemy import testing
 from sqlalchemy import ForeignKey
@@ -52,6 +52,7 @@
 from sqlalchemy import Float
 from sqlalchemy import LargeBinary
 from sqlalchemy import String
+from sqlalchemy.sql.expression import cast
 from sqlalchemy.ext.declarative import declarative_base
 from sqlalchemy.orm import relation
 from sqlalchemy.orm import Session
@@ -1300,6 +1301,13 @@ def test_float_as_float(self):
             filter_=lambda n: n is not None and round(n, 5) or None,
         )
 
+    @testing.requires.literal_float_coercion
+    def test_float_coerce_round_trip(self, connection):
+        expr = 15.7563
+
+        val = connection.scalar(select(cast(literal(expr), FLOAT)))
+        eq_(val, expr)
+
     @requires.precision_numerics_general
     def test_precision_decimal(self):
         """

test/test_suite_14.py

@@ -27,7 +27,7 @@
 from google.cloud.spanner_v1 import RequestOptions, Client
 
 import sqlalchemy
-from sqlalchemy import create_engine
+from sqlalchemy import create_engine, literal, FLOAT
 from sqlalchemy import inspect
 from sqlalchemy import testing
 from sqlalchemy import ForeignKey
@@ -53,6 +53,7 @@
 from sqlalchemy import Float
 from sqlalchemy import LargeBinary
 from sqlalchemy import String
+from sqlalchemy.sql.expression import cast
 from sqlalchemy.ext.declarative import declarative_base
 from sqlalchemy.orm import relation
 from sqlalchemy.orm import Session
@@ -1650,6 +1651,13 @@ def test_float_as_float(self, do_numeric_test):
             filter_=lambda n: n is not None and round(n, 5) or None,
         )
 
+    @testing.requires.literal_float_coercion
+    def test_float_coerce_round_trip(self, connection):
+        expr = 15.7563
+
+        val = connection.scalar(select(cast(literal(expr), FLOAT)))
+        eq_(val, expr)
+
     @requires.precision_numerics_general
     def test_precision_decimal(self, do_numeric_test):
         """

test/test_suite_20.py

@@ -26,7 +26,7 @@
 
 from google.cloud.spanner_v1 import RequestOptions, Client
 import sqlalchemy
-from sqlalchemy import create_engine
+from sqlalchemy import create_engine, literal, FLOAT
 from sqlalchemy.engine import Inspector
 from sqlalchemy import inspect
 from sqlalchemy import testing
@@ -55,6 +55,7 @@
 from sqlalchemy import Float
 from sqlalchemy import LargeBinary
 from sqlalchemy import String
+from sqlalchemy.sql.expression import cast
 from sqlalchemy.ext.declarative import declarative_base
 from sqlalchemy.orm import relationship
 from sqlalchemy.orm import Session
@@ -2455,6 +2456,13 @@ def test_float_as_float(self, do_numeric_test):
             filter_=lambda n: n is not None and round(n, 5) or None,
         )
 
+    @testing.requires.literal_float_coercion
+    def test_float_coerce_round_trip(self, connection):
+        expr = 15.7563
+
+        val = connection.scalar(select(cast(literal(expr), FLOAT)))
+        eq_(val, expr)
+
     @requires.precision_numerics_general
     def test_precision_decimal(self, do_numeric_test):
         """