Skip to content

Commit 5a2735b

Browse files
committed
Merge branch 'main' into PR #2663 to update
2 parents 91c5723 + f142db8 commit 5a2735b

File tree

6 files changed

+25
-17
lines changed

6 files changed

+25
-17
lines changed

.github/release-please.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
bumpMinorPreMajor: true
22
handleGHRelease: true
33
releaseType: java-yoshi
4+
extraFiles:
5+
- google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/Version.java
46
branches:
57
- bumpMinorPreMajor: true
68
handleGHRelease: true
@@ -86,5 +88,11 @@ branches:
8688
- >-
8789
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/Version.java
8890
branch: 2.60.x
89-
extraFiles:
90-
- google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/Version.java
91+
- bumpMinorPreMajor: true
92+
handleGHRelease: true
93+
releaseType: java-yoshi
94+
extraFiles:
95+
- >-
96+
google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/Version.java
97+
branch: protobuf-4.x-rc
98+
manifest: true

.kokoro/presubmit/graalvm-native-a.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Configure the docker image for kokoro-trampoline.
44
env_vars: {
55
key: "TRAMPOLINE_IMAGE"
6-
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_a:3.53.0" # {x-version-update:google-cloud-shared-dependencies:current}
6+
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_a:3.54.1" # {x-version-update:google-cloud-shared-dependencies:current}
77
}
88

99
env_vars: {

.kokoro/presubmit/graalvm-native-b.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Configure the docker image for kokoro-trampoline.
44
env_vars: {
55
key: "TRAMPOLINE_IMAGE"
6-
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_b:3.53.0" # {x-version-update:google-cloud-shared-dependencies:current}
6+
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_b:3.54.1" # {x-version-update:google-cloud-shared-dependencies:current}
77
}
88

99
env_vars: {

.kokoro/presubmit/graalvm-native-c.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Configure the docker image for kokoro-trampoline.
44
env_vars: {
55
key: "TRAMPOLINE_IMAGE"
6-
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_c:3.53.0" # {x-version-update:google-cloud-shared-dependencies:current}
6+
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_c:3.54.1" # {x-version-update:google-cloud-shared-dependencies:current}
77
}
88

99
env_vars: {

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/changestream/ReadChangeStreamMergingAcceptanceTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -285,20 +285,20 @@ public void test() throws Exception {
285285

286286
private static boolean expectsError(ReadChangeStreamTest testCase) {
287287
List<ReadChangeStreamTest.Result> results = testCase.getResultsList();
288-
return results != null && !results.isEmpty() && results.get(results.size() - 1).getError();
288+
return !results.isEmpty() && results.get(results.size() - 1).getError();
289289
}
290290

291291
private static List<ReadChangeStreamTest.Result> getNonExceptionResults(
292292
ReadChangeStreamTest testCase) {
293293
List<ReadChangeStreamTest.Result> results = testCase.getResultsList();
294294
List<ReadChangeStreamTest.Result> response = new ArrayList<>();
295-
if (results != null) {
296-
for (ReadChangeStreamTest.Result result : results) {
297-
if (!result.getError()) {
298-
response.add(result);
299-
}
295+
296+
for (ReadChangeStreamTest.Result result : results) {
297+
if (!result.getError()) {
298+
response.add(result);
300299
}
301300
}
301+
302302
return response;
303303
}
304304
}

google-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsMergingAcceptanceTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -142,20 +142,20 @@ public void test() throws Exception {
142142

143143
private static boolean expectsError(ReadRowsTest rrt) {
144144
List<ReadRowsTest.Result> results = rrt.getResultsList();
145-
return results != null && !results.isEmpty() && results.get(results.size() - 1).getError();
145+
return !results.isEmpty() && results.get(results.size() - 1).getError();
146146
}
147147

148148
private static List<ReadRowsTest.Result> getNonExceptionResults(ReadRowsTest rrt) {
149149
List<ReadRowsTest.Result> results = rrt.getResultsList();
150150

151151
List<ReadRowsTest.Result> response = new ArrayList<>();
152-
if (results != null) {
153-
for (ReadRowsTest.Result result : results) {
154-
if (!result.getError()) {
155-
response.add(result);
156-
}
152+
153+
for (ReadRowsTest.Result result : results) {
154+
if (!result.getError()) {
155+
response.add(result);
157156
}
158157
}
158+
159159
return response;
160160
}
161161
}

0 commit comments

Comments
 (0)