This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Fix instantiation expr. args. in TypeScript.#483
Closed
bm-w wants to merge 1 commit intogithub:mainfrom
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where instantiation_expression syntax nodes were not included in the list of basic expressions, causing errors when handling function argument lexical scopes.
- Added a new test file to verify that instantiation expressions are properly handled.
- The new test confirms that the fix resolves the error when using instantiation expressions as call arguments.
Files not reviewed (1)
- languages/tree-sitter-stack-graphs-typescript/src/stack-graphs.tsg: Language not supported
Contributor
|
The github/stack-graphs repository is no longer being maintained. As per #502, I'm closing all issues and pull requests before archiving the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instantiation_expressionsyntax nodes were not included in the list of basic expressions, and thus the@expr.lexical_scopegraph node was not being created for them. This caused an error in the stanza that deals with function arguments, e.g.:Simply including
instantiation_expressionsyntax nodes in the list fixe the issue. Copious testing (on our TS test suite and on all of microsoft/vscode) reveals no negative side effects.Actually resolving a reference appearing in an instantiation expression as call argument does not work — I left a
TODO.