Skip to content

Commit 561d04e

Browse files
committed
scripts(fix[ci-smoke]): pass sphinx and typehints-gp wheel as separate install args
why: smoke_sphinx_autodoc_typehints_gp passed f"sphinx {dist_dir}/sphinx_autodoc_typehints_gp-{version}-py3-none-any.whl" as a single positional to _install_into_venv. That helper is variadic (*requirements) and forwards each arg as its own token to uv pip install, so the concatenated string became one requirement with a literal space in the name — uv would reject it as a syntactically invalid requirement. Every other smoke_* in this module already uses the _target_wheel_path() helper; this one was an oversight. what: - Replace the f-string with two positional arguments: "sphinx" and _target_wheel_path(dist_dir, "sphinx-autodoc-typehints-gp"). - Matches the idiom used by the other smoke_* functions in the same file.
1 parent 8dc6ba7 commit 561d04e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

scripts/ci/package_tools.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,8 @@ def smoke_sphinx_autodoc_typehints_gp(dist_dir: pathlib.Path, version: str) -> N
462462
python_path = _create_venv(tmpdir)
463463
_install_into_venv(
464464
python_path,
465-
f"sphinx {dist_dir}/sphinx_autodoc_typehints_gp-{version}-py3-none-any.whl",
465+
"sphinx",
466+
_target_wheel_path(dist_dir, "sphinx-autodoc-typehints-gp"),
466467
)
467468
_run_sphinx_build(python_path, docs_dir, tmpdir / "build")
468469

0 commit comments

Comments
 (0)