feat(trace): Add timeouts to the trace query #104554
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
+497
to
+502
| TRACE_QUERY_TIMEOUT = options.get("performance.traces.endpoint.query-timeout") | ||
| results = {} | ||
| for future in queries: | ||
| label = queries[future] | ||
| try: | ||
| results[label] = future.get(timeout=TRACE_QUERY_TIMEOUT) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- This adds a timeout to the queries for the trace endpoint so that the entire endpoint doesn't fail if one of the datasets takes too long to execute - Had to switch to multiprocessing because threadpool doesn't have a good way to kill running tasks when they hit timeout? afaict it will wait until all tasks finish before letting you do anything
wmak
force-pushed
the
wmak/feat/add-timeouts-to-the-trace-query
branch
from
ab9f609 to
f5dc950
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #104554 +/- ##
============================================
+ Coverage 65.78% 80.54% +14.76%
============================================
Files 9338 9346 +8
Lines 399925 400312 +387
Branches 25621 25621
============================================
+ Hits 263087 322429 +59342
+ Misses 136389 77434 -58955
Partials 449 449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.