-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore(cells) Switch ReactView and GenericReactView to control silo #104552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
markstory
wants to merge
1
commit into
master
Choose a base branch
from
chore-reactpage-silo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We render the bulk of our HTML via ReactPage. Right now that endpoint is marked as `all_silo` to make integration with tests simpler. Switch these endpoints to control as we're trying to have a minimal number of endpoints marked as `all_silo` and I want to better understand the scope of test failures from this change. Refs INFRENG-238
❌ 9 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We render the bulk of our HTML via ReactPage. Right now that endpoint is marked as
all_siloto make integration with tests simpler. Switch these endpoints to control as we're trying to have a minimal number of endpoints marked asall_siloand I want to better understand the scope of test failures from this change.Refs INFRENG-238