quickshell: fix warnings

Author: fufexan

home/services/quickshell/bar/Battery.qml

@@ -28,7 +28,7 @@ HoverTooltip {
 
         source: {
             const nearestTen = Math.round(root.percentage / 10) * 10;
-            const number = nearestTen.toString().padStart(2, "0");
+            const number = nearestTen.toString();
             let charging;
 
             if (root.battery.state == UPowerDeviceState.Charging) {

home/services/quickshell/bar/Network.qml

@@ -9,25 +9,25 @@ import qs.utils
 HoverTooltip {
     id: root
 
-    property NetworkDevice adapter: Networking.devices.values[0]
+    property NetworkDevice adapter: Networking.devices?.values[0] ?? null
 
-	readonly property WifiNetwork activeNetwork: adapter.networks.values.find(network => network.connected)
+    readonly property WifiNetwork activeNetwork: adapter?.networks?.values.find(network => network.connected) ?? null
 
-    visible: !!Networking.devices.values
+    visible: !!Networking.devices?.values
 
     readonly property string iconState: {
         if (!Networking.wifiHardwareEnabled)
             return "hardware-disabled";
         else if (!Networking.wifiEnabled)
             return "disabled";
-        else if (adapter.state == DeviceConnectionState.Connecting || adapter.state == DeviceConnectionState.Disconnecting)
+        else if (adapter?.state == DeviceConnectionState.Connecting || adapter?.state == DeviceConnectionState.Disconnecting)
             return "acquiring";
-        else if (adapter.connected) {
+        else if (adapter?.connected) {
             let strength = "good";
 
-            if (activeNetwork.signalStrength >= 0.66) {
+            if (activeNetwork?.signalStrength >= 0.66) {
                 strength = "good";
-            } else if (activeNetwork.signalStrength >= 0.33) {
+            } else if (activeNetwork?.signalStrength >= 0.33) {
                 strength = "ok";
             } else {
                 strength = "weak";
@@ -41,15 +41,12 @@ HoverTooltip {
     text: {
         if (!Networking.wifiEnabled)
             return "WiFi disabled";
-
-        else if (adapter.state == DeviceConnectionState.Connecting)
+        else if (adapter?.state == DeviceConnectionState.Connecting)
             return `Connecting to ${activeNetwork.name}`;
-
-        else if (adapter.state == DeviceConnectionState.Disconnecting)
+        else if (adapter?.state == DeviceConnectionState.Disconnecting)
             return `Disconnecting from ${activeNetwork.name}`;
-
-        else if (adapter.connected)
-            return activeNetwork.name;
+        else if (adapter?.connected)
+            return activeNetwork?.name ?? null;
 
         return "Disconnected";
     }

home/services/quickshell/bar/Workspaces.qml

@@ -79,7 +79,7 @@ WrapperMouseArea {
                         radius: height / 2
 
                         color: {
-                            ws.modelData.workspace ?? false ? Colors.monitorColors[ws.modelData.workspace?.monitor?.id] : Colors.bgBar;
+                            ws.modelData.workspace ?? false ? Colors.monitorColors[ws.modelData.workspace?.monitor?.id ?? 0] : Colors.bgBar;
                         }
 
                         implicitHeight: parent.height

home/services/quickshell/components/MaterialIcon.qml

@@ -1,16 +1,20 @@
 import qs.utils
 
 Text {
+    id: root
     property real fill: 0
     // property int grade: Colours.light ? 0 : -25
     property int grade: -25
 
+    readonly property int targetSize: font.pointSize
+    readonly property int targetWeight: font.weight
+
     font.family: "Material Symbols Rounded"
     font.pointSize: Config.iconSize + 1
     font.variableAxes: ({
             FILL: fill.toFixed(1),
             GRAD: grade,
-            opsz: font.pixelSize,
-            wght: font.weight
+            opsz: root.targetSize,
+            wght: root.targetWeight
         })
 }

home/services/quickshell/osd/OSD.qml

@@ -13,7 +13,7 @@ Scope {
     property string icon: ""
 
     Connections {
-        target: PipeWireState.defaultSink?.audio
+        target: PipeWireState.defaultSink ? PipeWireState.defaultSink.audio : null
 
         function update() {
             scope.osdVisible = true;
@@ -32,7 +32,7 @@ Scope {
     }
 
     Connections {
-        target: PipeWireState.defaultSource?.audio
+        target: PipeWireState.defaultSource ? PipeWireState.defaultSource.audio : null
 
         function update() {
             scope.osdVisible = true;

home/services/quickshell/utils/BrightnessState.qml

@@ -7,15 +7,16 @@ Singleton {
     id: root
 
     property real brightness: persist.brightness
+    property bool interfaceReady: false
 
     PersistentProperties {
         id: persist
         reloadableId: "persistedBrightness"
         property string screenInterface: ""
         readonly property string path: `/sys/class/backlight/${screenInterface}`
-        readonly property int rawBrightness: Number(getRawBrightness.text());
-        readonly property int max: Number(getMaxBrightness.text());
-        readonly property real brightness: rawBrightness / max;
+        readonly property int rawBrightness: screenInterface !== "" ? Number(getRawBrightness.text()) : 0
+        readonly property int max: screenInterface !== "" ? Number(getMaxBrightness.text()) : 1
+        readonly property real brightness: max > 0 ? rawBrightness / max : 0
     }
 
     Process {
@@ -25,20 +26,21 @@ Singleton {
         command: ["sh", "-c", "ls -w1 /sys/class/backlight | head -1"]
         stdout: SplitParser {
             onRead: data => {
-                persist.screenInterface = data;
+                persist.screenInterface = data.trim();
+                root.interfaceReady = true;
             }
         }
     }
 
     FileView {
         id: getMaxBrightness
-        path: `${persist.path}/max_brightness`
+        path: !!persist.screenInterface && root.interfaceReady ? `${persist.path}/max_brightness` : ""
         blockLoading: true
     }
 
     FileView {
         id: getRawBrightness
-        path: `${persist.path}/brightness`
+        path: !!persist.screenInterface && root.interfaceReady ? `${persist.path}/brightness` : ""
         blockLoading: true
 
         watchChanges: true

home/services/quickshell/utils/NotificationState.qml

@@ -82,7 +82,7 @@ Singleton {
             notif.tracked = true;
             notif.time = Date.now();
             root.onNewNotif(notif);
-            console.log("notif: appName", notif.appName || "null", ", appIcon", notif.appIcon || "null", ", image", notif.image || "null", ", expireTimeout", notif.expireTimeout)
+            // console.log("notif: appName", notif.appName || "null", ", appIcon", notif.appIcon || "null", ", image", notif.image || "null", ", expireTimeout", notif.expireTimeout)
 
             notif.closed.connect(() => {
                 notifDismissByNotif(notif);