Why it doesn't scan all branches in actual run mode?

[lal2hc]

I am using the latest version fpicalausa/remove-stale-branches@v2.2.0 with below options

Run fpicalausa/remove-stale-branches@v2.2.0
  with:
    dry-run: false
    github-token: ***
    operations-per-run: 5000
    exempt-protected-branches: true
    exempt-branches-regex: ^(?!.*stale-branch).+$
    ignore-branches-with-open-prs: true
    days-before-branch-stale: 10
    days-before-branch-delete: 7
    stale-branch-message: @{author} Your branch hasn't been updated in the last {daysBeforeBranchStale} days and is marked as stale. It will be removed in {daysBeforeBranchDelete} days. If you want to keep this branch around, delete this comment or add new commits to this branch.
    ignore-unknown-authors: false

With dry-run=true
Summary: 380 scanned, ✅ 2 skipped, ✏ 0 marked stale, 😐 10 kept stale, ❌ 368 removed

With dry-run=false
Summary: 200 scanned, ✅ 1 skipped, ✏ 0 marked stale, 😐 10 kept stale, ❌ 189 removed

Do you know why it doesn't scan all branches in actual run mode?

[lal2hc]

Hi @fpicalausa, Please help to take a look on it.

[francoisp-houzz]

@lal2hc this does seem like a bug indeed. Perhaps removing branches doesn't play well with the pagination.

Unfortunately I don't have much bandwidth to look at a fix, but I yake a look at PRs every couple of months 🙏🏼

[dkv1hc]

Hello @lal2hc , @fpicalausa ,

[Rough Analysis] Seem that the cause came from "Modifying/Remove the Stale Branch While iterating over the responded pagination Array/List"

• Loop branches:

  remove-stale-branches/src/removeStaleBranches.ts

  Line 277 in 68ab5e7

  for await (const branch of readBranches(

• [Causing Issue] Removing Stale branch while iterating over that list:

  remove-stale-branches/src/removeStaleBranches.ts

  Line 81 in 68ab5e7

  commitComments.deleteBranch(branch);

It's just a rough check. Please help to check again. Thank you