Skip to content

extraCoreComponentPodConfig nesting error in deployment-template #39

@leonbrandt

Description

@leonbrandt

templates/deployment.yaml contains the following block at line 697:

---
{{- if .Values.kafka.authentication.tls.enabled }}
...
{{- end }}
{{- if .Values.extraCoreComponentPodConfig }}
{{ toYaml .Values.extraCoreComponentPodConfig | indent 6 -}}
{{- end }}

which leads to the generation of a single extraCoreComponentPodConfig-block after rendering the template whenever it is defined. I'm quite sure the extraCoreComponentPodConfig-block should be inside the kafka.authentication.tls.enabled-block above.


For example if my values-file contains this:

extraCoreComponentPodConfig:
  tolerations:
  - key: faas
    operator: Exists
    effect: NoSchedule

the rendered template will contain this:

---
# Source: fission-all/templates/deployment.yaml
tolerations:
      - effect: NoSchedule
        key: faas
        operator: Exists
---

which obviously isn't a valid kubernetes-object.

Tested in fission-all-1.12.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions