Do not print out lots of caching and object finalisation info in CI

It makes the output much harder to read and understand, especially since
we already have interleaved output for the different jobs. It is also
not very useful information for the vast majority of PRs.

Author: connorjward

.github/workflows/core.yml

@@ -91,7 +91,6 @@ jobs:
       OMP_NUM_THREADS: 1
       OPENBLAS_NUM_THREADS: 1
       FIREDRAKE_CI: 1
-      PYOP2_CI_TESTS: 1
       PYOP2_SPMD_STRICT: 1
       # NOTE: One should occasionally update test_durations.json by running
       # 'make test_durations' inside a 'firedrake:latest' Docker image.

pyop2/caching.py

@@ -61,8 +61,6 @@
 # in _KNOWN_CACHES
 _CACHE_CIDX = count()
 _KNOWN_CACHES = []
-# Flag for outputting information at the end of testing (do not abuse!)
-_running_on_ci = bool(os.environ.get('PYOP2_CI_TESTS'))
 
 
 # FIXME: (Later) Remove ObjectCached
@@ -265,10 +263,6 @@ def print_cache_stats(*args, **kwargs):
         print(hline)
 
 
-if _running_on_ci:
-    print_cache_stats = atexit.register(print_cache_stats)
-
-
 class _CacheMiss:
     pass
 
@@ -436,7 +430,7 @@ class DEFAULT_CACHE(dict):
 # EXOTIC_CACHE = partial(instrument(cachetools.LRUCache), maxsize=100)
 
 # Turn on cache measurements if printing cache info is enabled
-if configuration["print_cache_info"] or _running_on_ci:
+if configuration["print_cache_info"]:
     DEFAULT_CACHE = instrument(DEFAULT_CACHE)
     DictLikeDiskAccess = instrument(DictLikeDiskAccess)
 

pyop2/mpi.py

@@ -76,8 +76,6 @@
 _DUPED_COMM_DICT = {}
 # Flag to indicate whether we are in cleanup (at exit)
 PYOP2_FINALIZED = False
-# Flag for outputting information at the end of testing (do not abuse!)
-_running_on_ci = bool(os.environ.get('PYOP2_CI_TESTS'))
 
 
 class PyOP2CommError(ValueError):
@@ -549,12 +547,10 @@ def finalize_safe_debug():
     finished writing debug information. In this case we fall back to using the
     Python `print` function to output debugging information.
 
-    Furthermore, we always want to see this finalization information when
-    running the CI tests.
     '''
     global debug
     if PYOP2_FINALIZED:
-        if logger.level > DEBUG and not _running_on_ci:
+        if logger.level > DEBUG:
             debug = lambda string: None
         else:
             debug = lambda string: print(string)