Skip to content

Commit eab0a13

Browse files
committed
test(hotplug): enable RSS assertion for secret_free and fix VM leak
Now that discard_range() uses fallocate(PUNCH_HOLE) for guest_memfd, and get_resident_memory() uses guest meminfo for secret_free VMs, the RSS decrease assertion in check_hotunplug works correctly for secret_free. Remove the skip. Signed-off-by: Jack Thomson <jackabt@amazon.com>
1 parent 8161213 commit eab0a13

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

tests/integration_tests/performance/test_hotplug_memory.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,8 +289,10 @@ def check_hotunplug(uvm, requested_size_mib):
289289
machine_config = uvm.api.machine_config.get().json()
290290
huge_pages = HugePagesConfig(machine_config["huge_pages"])
291291
secret_free = machine_config.get("secret_free", False)
292-
if not secret_free and (
293-
huge_pages == HugePagesConfig.NONE or supports_hugetlbfs_discard()
292+
if (
293+
secret_free
294+
or huge_pages == HugePagesConfig.NONE
295+
or supports_hugetlbfs_discard()
294296
):
295297
assert rss_after < rss_before, "RSS didn't decrease"
296298

0 commit comments

Comments
 (0)