Unmounting workaround assumes util-linux mount implementation

[vazub]

finit/src/sig.c

Line 389 in e1fe870

run("mount -n -o remount,ro -t dummytype dummydev /", NULL);

Not a bug, but a curious implicit assumption, of using mount command from the util-linux package. When using other implementations, that do not support some of the options, e.g. from toybox or busybox, the command fails. Would it be reasonable to avoid running a dedicated command and call something from sys/mount.h instead?

[troglobit]

Barely remember this one, but it works for me with BusyBox.

[vazub]

Ok, I might have been wrong here indeed. My initial assumption was based on this issue I am facing:

I tracked it to the code part mentioned, and assumed it was the culprit. But having tested it again with 3 mount implementations (BusyBox, Toybox, util-linux), the issue persists for each of them, so apparently something else is at play here. Will have to debug more and look for more insights.

[vazub]

Alright, an update here. I found out that for some reason, at least with my build of finit for my custom non-FSH distro, the PATH is not getting parsed properly, so therefore initctl can not find commands it shells out to. This affects mount as in example above, as well as any service stanzas. A mitigation for this is to always use absolute paths, then it works fine. Still puzzled though as to why this happens, as based on the code finit is supposed to use either PATH returned by env, or _PATH_DEFPATH, or _PATH_STDPATH. My distro keeps everything in /bin, and all these env vars do contain it as part of specification. Not sure yet what causes this weird behavior. Seeing as no one raised this issue before, I tend to assume this is my special case?

[troglobit]

Which version of Finit are you on? Since 21753e2 (4.15-rc2) we've added guard very early to set _PATH_STDPATH, maybe that's what you are referring to?

I honestly have no idea why you're the only one seeing this, sorry that I cannot be of more help!