Avoid crash when dragging files from WinRAR (#5999)

Author: gave92

Files/BaseLayout.cs

@@ -879,6 +879,7 @@ protected async void Item_DragOver(object sender, DragEventArgs e)
                 e.Handled = true;
 
                 var (handledByFtp, draggedItems) = await Filesystem.FilesystemHelpers.GetDraggedStorageItems(e.DataView);
+                draggedItems ??= new List<IStorageItemWithPath>();
 
                 if (draggedItems.Any(draggedItem => draggedItem.Path == item.ItemPath))
                 {

Files/Filesystem/FilesystemOperations/Helpers/FilesystemHelpers.cs

@@ -583,6 +583,7 @@ public async Task<ReturnResult> CopyItemAsync(IStorageItemWithPath source, strin
         public async Task<ReturnResult> CopyItemsFromClipboard(DataPackageView packageView, string destination, bool showDialog, bool registerHistory)
         {
             var (handledByFtp, source) = await GetDraggedStorageItems(packageView);
+            source ??= new List<IStorageItemWithPath>();
 
             if (handledByFtp)
             {
@@ -814,6 +815,7 @@ public async Task<ReturnResult> MoveItemsFromClipboard(DataPackageView packageVi
             }
 
             var (handledByFtp, source) = await GetDraggedStorageItems(packageView);
+            source ??= new List<IStorageItemWithPath>();
 
             if (handledByFtp)
             {
@@ -913,6 +915,7 @@ public async Task<ReturnResult> CreateShortcutFromClipboard(DataPackageView pack
             }
 
             var (handledByFtp, source) = await GetDraggedStorageItems(packageView);
+            source ??= new List<IStorageItemWithPath>();
 
             if (handledByFtp)
             {
@@ -948,6 +951,7 @@ public async Task<ReturnResult> RecycleItemsFromClipboard(DataPackageView packag
             }
 
             var (handledByFtp, source) = await GetDraggedStorageItems(packageView);
+            source ??= new List<IStorageItemWithPath>();
 
             if (handledByFtp)
             {

Files/Interacts/BaseLayoutCommandImplementationModel.cs

@@ -535,6 +535,7 @@ public virtual async Task DragOver(DragEventArgs e)
                 e.Handled = true;
 
                 var (handledByFtp, draggedItems) = await Filesystem.FilesystemHelpers.GetDraggedStorageItems(e.DataView);
+                draggedItems ??= new List<IStorageItemWithPath>();
 
                 var pwd = associatedInstance.FilesystemViewModel.WorkingDirectory.TrimPath();
                 var folderName = (Path.IsPathRooted(pwd) && Path.GetPathRoot(pwd) == pwd) ? Path.GetPathRoot(pwd) : Path.GetFileName(pwd);

Files/UserControls/SidebarControl.xaml.cs

@@ -558,6 +558,7 @@ private async void NavigationViewLocationItem_DragOver(object sender, DragEventA
                 e.Handled = true;
 
                 var (handledByFtp, storageItems) = await Filesystem.FilesystemHelpers.GetDraggedStorageItems(e.DataView);
+                storageItems ??= new List<IStorageItemWithPath>();
 
                 if (string.IsNullOrEmpty(locationItem.Path) ||
                     (storageItems.Any() && storageItems.AreItemsAlreadyInFolder(locationItem.Path))
@@ -699,6 +700,7 @@ private async void NavigationViewDriveItem_DragOver(object sender, DragEventArgs
             e.Handled = true;
 
             var (handledByFtp, storageItems) = await Filesystem.FilesystemHelpers.GetDraggedStorageItems(e.DataView);
+            storageItems ??= new List<IStorageItemWithPath>();
 
             if ("DriveCapacityUnknown".GetLocalized().Equals(driveItem.SpaceText, StringComparison.OrdinalIgnoreCase) ||
                 (storageItems.Any() && storageItems.AreItemsAlreadyInFolder(driveItem.Path)))

Files/ViewModels/NavToolbarViewModel.cs

@@ -443,6 +443,8 @@ public async void PathBoxItem_DragOver(object sender, DragEventArgs e)
             var deferral = e.GetDeferral();
 
             var (handledByFtp, storageItems) = await Filesystem.FilesystemHelpers.GetDraggedStorageItems(e.DataView);
+            storageItems ??= new List<IStorageItemWithPath>();
+
             if (handledByFtp)
             {
                 e.AcceptedOperation = DataPackageOperation.None;

Files/ViewModels/Widgets/Bundles/BundleContainerViewModel.cs

@@ -312,6 +312,7 @@ private async Task Drop(DragEventArgs e)
                 if (Filesystem.FilesystemHelpers.HasDraggedStorageItems(e.DataView))
                 {
                     var (_, items) = await Filesystem.FilesystemHelpers.GetDraggedStorageItems(e.DataView);
+                    items ??= new List<IStorageItemWithPath>();
 
                     if (await AddItemsFromPath(items.ToDictionary((item) => item.Path, (item) => item.ItemType)))
                     {