Remove Commit from FrameTimingSequence #54779
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: # Changelog: [Internal] This is not required for displaying the Frames track. In Chrome, I've noticed that "Commit" is actually a complete event (`ph = X`), and it has a `disabled-by-default-devtools.timeline`. Frames events, like `BeginFrame`, `DrawFrame`, `DroppedFrame` have `.frame` suffix in a category. This event being a complete event actually makes lot of sense, since this is a work with some duration, where Host spent time committing the changes. In React Native case, this should probably reflect the `completeRoot()` call or some proxy from it. Basically the duration of committing tree operations in Fabric. Differential Revision: D88382285
meta-cla
bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
This is not required for displaying the Frames track.
In Chrome, I've noticed that "Commit" is actually a complete event (
ph = X), and it has adisabled-by-default-devtools.timeline. Frames events, likeBeginFrame,DrawFrame,DroppedFramehave.framesuffix in a category.This event being a complete event actually makes lot of sense, since this is a work with some duration, where Host spent time committing the changes. In React Native case, this should probably reflect the
completeRoot()call or some proxy from it. Basically the duration of committing tree operations in Fabric.Differential Revision: D88382285