Commit dc73ec4
fix: RNGP using node invocation non-compatible with Gradle Compilation Cache (#54801)
Summary:
Invoking `Runtime.getRuntime().exec()` is not compatible with Gradle Configuration Cache and providers should be used instead.
This error hasn't surfaced yet due to fact that this branch of code is rarely hit as the users usually provide correct path to the CLI in their `app/build.gradle` file. I stumbled upon it accidentally when bumping RN in monorepo and the CLI path was no longer valid.
## Changelog:
[ANDROID] [FIXED] - RNGP using node invocation non-compatible with Gradle Compilation Cache
Pull Request resolved: #54801
Test Plan: I tested it in a rnc-cli app, where I provided an invalid path for `cliFile` - the error was fixed after applying this patch.
Reviewed By: mdvacca, huntie
Differential Revision: D88492310
Pulled By: cortinico
fbshipit-source-id: a91e47b90937945066bde938bdf16b2550322afb1 parent 38513f7 commit dc73ec4
File tree
1 file changed
+11
-9
lines changed- packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils
1 file changed
+11
-9
lines changedLines changed: 11 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
71 | 72 | | |
72 | 73 | | |
73 | 74 | | |
74 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
75 | 80 | | |
76 | 81 | | |
77 | 82 | | |
| |||
81 | 86 | | |
82 | 87 | | |
83 | 88 | | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
92 | 94 | | |
93 | 95 | | |
94 | 96 | | |
| |||
0 commit comments