Skip to content

Commit 034093f

Browse files
benoit-nexthopmeta-codesync[bot]
authored andcommitted
Don't use the root group (#690)
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - - [x] `pre-commit run` In commit 7b36e2f (#641) I mistakenly added the user to the `root` group, which is not necessary and gives more privileges than we want to have. Pull Request resolved: #690 Test Plan: Not needed. Reviewed By: shiva-menta Differential Revision: D88080346 Pulled By: KevinYakar fbshipit-source-id: 82b004ff866721729661a974a16ae064ab12af48
1 parent 426c232 commit 034093f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fboss/oss/docker/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ RUN echo "%wheel ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers
116116
# Create user if USERNAME is not root
117117
RUN if [ "$USERNAME" != "root" ] && [ "$USER_UID" != "0" ]; then \
118118
groupadd -g $USER_GID $USERNAME && \
119-
useradd -l -m -u $USER_UID -g $USER_GID -G root,adm,wheel,users -s $USER_SHELL $USERNAME && \
119+
useradd -l -m -u $USER_UID -g $USER_GID -G adm,wheel,users -s $USER_SHELL $USERNAME && \
120120
chown -R $USERNAME /var/FBOSS; \
121121
fi
122122

0 commit comments

Comments
 (0)