Skip to content

Commit 6c46c19

Browse files
authored
Merge pull request #17 from extism/chicory-1.0.0-M2
bump: chicory 1.0.0-M2
2 parents 0ff3ba0 + f84837c commit 6c46c19

File tree

4 files changed

+17
-19
lines changed

4 files changed

+17
-19
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363

6464
<java.version>11</java.version>
6565

66-
<chicory.version>1.0.0-M1</chicory.version>
66+
<chicory.version>1.0.0-M2</chicory.version>
6767
<junit.version>3.8.1</junit.version>
6868

6969
<maven-compiler-plugin.version>3.10.1</maven-compiler-plugin.version>

src/main/java/org/extism/chicory/sdk/ChicoryModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,16 @@
22

33
import com.dylibso.chicory.experimental.aot.AotMachine;
44
import com.dylibso.chicory.runtime.Instance;
5-
import com.dylibso.chicory.wasm.Module;
65
import com.dylibso.chicory.wasm.Parser;
6+
import com.dylibso.chicory.wasm.WasmModule;
77

88
import java.nio.file.Path;
99

1010
class ChicoryModule {
1111

1212
static final boolean IS_NATIVE_IMAGE_AOT = Boolean.getBoolean("com.oracle.graalvm.isaot");
1313

14-
static Module fromWasm(ManifestWasm m) {
14+
static WasmModule fromWasm(ManifestWasm m) {
1515
if (m instanceof ManifestWasmBytes) {
1616
ManifestWasmBytes mwb = (ManifestWasmBytes) m;
1717
return Parser.parse(mwb.bytes);

src/main/java/org/extism/chicory/sdk/DependencyGraph.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,18 @@
44
import com.dylibso.chicory.runtime.ExportFunction;
55
import com.dylibso.chicory.runtime.HostFunction;
66
import com.dylibso.chicory.runtime.ImportFunction;
7-
import com.dylibso.chicory.runtime.ImportValue;
87
import com.dylibso.chicory.runtime.ImportValues;
98
import com.dylibso.chicory.runtime.Instance;
109
import com.dylibso.chicory.runtime.Store;
1110
import com.dylibso.chicory.runtime.WasmFunctionHandle;
12-
import com.dylibso.chicory.wasm.Module;
11+
import com.dylibso.chicory.wasm.WasmModule;
1312
import com.dylibso.chicory.wasm.types.Export;
1413
import com.dylibso.chicory.wasm.types.ExportSection;
1514
import com.dylibso.chicory.wasm.types.ExternalType;
1615
import com.dylibso.chicory.wasm.types.FunctionImport;
1716
import com.dylibso.chicory.wasm.types.FunctionType;
1817
import com.dylibso.chicory.wasm.types.Import;
1918
import com.dylibso.chicory.wasm.types.ImportSection;
20-
import com.dylibso.chicory.wasm.types.Value;
2119

2220
import java.util.ArrayList;
2321
import java.util.HashMap;
@@ -36,7 +34,7 @@ class DependencyGraph {
3634
private final Logger logger;
3735

3836
private final Map<String, Set<String>> registeredSymbols = new HashMap<>();
39-
private final Map<String, Module> modules = new HashMap<>();
37+
private final Map<String, WasmModule> modules = new HashMap<>();
4038
private final Set<String> hostModules = new HashSet<>();
4139
private final Map<String, Instance> instances = new HashMap<>();
4240
private final Map<QualifiedName, Trampoline> trampolines = new HashMap<>();
@@ -93,7 +91,7 @@ private void checkCollision(String moduleName, String symbol) {
9391
/**
9492
* Register a Module with the given name.
9593
*/
96-
public void registerModule(String name, Module m) {
94+
public void registerModule(String name, WasmModule m) {
9795
checkCollision(name, null);
9896

9997
ExportSection exportSection = m.exportSection();
@@ -113,7 +111,7 @@ public void registerSymbol(String name, String symbol) {
113111
public boolean validate() {
114112
boolean valid = true;
115113
for (var kv : modules.entrySet()) {
116-
Module m = kv.getValue();
114+
WasmModule m = kv.getValue();
117115

118116
ImportSection imports = m.importSection();
119117
for (int i = 0; i < imports.importCount(); i++) {
@@ -156,7 +154,7 @@ public Instance instantiate() {
156154

157155
while (!unresolved.isEmpty()) {
158156
String moduleId = unresolved.peek();
159-
Module m = this.modules.get(moduleId);
157+
WasmModule m = this.modules.get(moduleId);
160158
boolean satisfied = true;
161159
List<HostFunction> trampolines = new ArrayList<>();
162160
ImportSection imports = m.importSection();
@@ -217,7 +215,7 @@ public Instance instantiate() {
217215
}
218216

219217
private Instance instantiate(String moduleId, List<HostFunction> moreHostFunctions) {
220-
Module m = this.modules.get(moduleId);
218+
WasmModule m = this.modules.get(moduleId);
221219
Objects.requireNonNull(m);
222220

223221
ImportValues importValues =
@@ -253,7 +251,7 @@ private ImportValues mergeImportValues(ImportValues hostImports, List<HostFuncti
253251
.addTable(hostImports.tables()).build();
254252
}
255253

256-
private HostFunction registerTrampoline(FunctionImport f, Module m) {
254+
private HostFunction registerTrampoline(FunctionImport f, WasmModule m) {
257255
// Trampolines are singletons for each <moduleName, name> pair.
258256
// Trampolines are not registered into the store, as they are not "real" functions.
259257
// They are instead kept separately and passed explicitly to the instance.

src/test/java/org/extism/chicory/sdk/DependencyGraphTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import com.dylibso.chicory.log.SystemLogger;
44
import com.dylibso.chicory.runtime.Instance;
55
import com.dylibso.chicory.wasi.WasiPreview1;
6-
import com.dylibso.chicory.wasm.Module;
6+
import com.dylibso.chicory.wasm.WasmModule;
77
import junit.framework.TestCase;
88

99
import java.io.IOException;
@@ -38,10 +38,10 @@ public void testCircularDepsMore() throws IOException {
3838
InputStream mainBytes = this.getClass().getResourceAsStream("/circular-import-more/circular-import-main.wasm");
3939

4040

41-
Module add = parse(addBytes);
42-
Module sub = parse(subBytes);
43-
Module expr = parse(exprBytes);
44-
Module main = parse(mainBytes);
41+
WasmModule add = parse(addBytes);
42+
WasmModule sub = parse(subBytes);
43+
WasmModule expr = parse(exprBytes);
44+
WasmModule main = parse(mainBytes);
4545

4646
{
4747
DependencyGraph dg = new DependencyGraph(new SystemLogger());
@@ -74,7 +74,7 @@ public void testCircularDepsMore() throws IOException {
7474

7575
public void testHostFunctionDeps() throws IOException {
7676
InputStream requireWasi = this.getClass().getResourceAsStream("/host-functions/import-wasi.wasm");
77-
Module requireWasiM = parse(requireWasi);
77+
WasmModule requireWasiM = parse(requireWasi);
7878

7979
DependencyGraph dg = new DependencyGraph(new SystemLogger());
8080
dg.registerFunctions(wasiPreview1().toHostFunctions());
@@ -88,7 +88,7 @@ public void testHostFunctionDeps() throws IOException {
8888

8989
public void testInstantiate() throws IOException {
9090
InputStream requireWasi = this.getClass().getResourceAsStream("/host-functions/import-wasi.wasm");
91-
Module requireWasiM = parse(requireWasi);
91+
WasmModule requireWasiM = parse(requireWasi);
9292

9393
DependencyGraph dg = new DependencyGraph(new SystemLogger());
9494
dg.registerFunctions(wasiPreview1().toHostFunctions());

0 commit comments

Comments
 (0)