Fix excludeBrowserFlags forwarding in dev config

Pass excludeBrowserFlags through webpack-config so browser flag exclusions reach the dev browser launcher

Author: cezaraugusto

ci-scripts/run-optional-deps-smoke.mjs

@@ -577,7 +577,12 @@ function runReactContentDevSmoke(workdir) {
 
   return new Promise((resolve, reject) => {
     const child = shouldUseDirectLocalCli('npm')
-      ? runExtensionCliLong(['dev', '--browser=chrome', '--no-browser'], workdir, smokeEnv, 'npm')
+      ? runExtensionCliLong(
+          ['dev', '--browser=chrome', '--no-browser'],
+          workdir,
+          smokeEnv,
+          'npm'
+        )
       : runLong(
           'npm',
           ['run', 'dev', '--', '--browser=chrome', '--no-browser'],

programs/develop/webpack/__spec__/webpack-config.spec.ts

@@ -153,4 +153,30 @@ describe('webpack-config transpile packages watch behavior', () => {
       })
     )
   })
+
+  it('forwards excludeBrowserFlags to BrowsersPlugin', () => {
+    resolveTranspilePackageDirsMock.mockReturnValue([])
+    BrowsersPluginMock.mockClear()
+
+    const projectStructure = createProjectStructure()
+    webpackConfig(
+      projectStructure as any,
+      {
+        browser: 'chromium',
+        mode: 'development',
+        output: {
+          clean: false,
+          path: '/project/dist/chromium'
+        },
+        excludeBrowserFlags: ['--hide-scrollbars', '--mute-audio'],
+        noBrowser: false
+      } as any
+    )
+
+    expect(BrowsersPluginMock).toHaveBeenCalledWith(
+      expect.objectContaining({
+        excludeBrowserFlags: ['--hide-scrollbars', '--mute-audio']
+      })
+    )
+  })
 })

programs/develop/webpack/webpack-config.ts

@@ -168,6 +168,7 @@ export default function webpackConfig(
         persistProfile: (devOptions as any).persistProfile,
         preferences: darkDefaults.preferences,
         browserFlags: darkDefaults.browserFlags,
+        excludeBrowserFlags: devOptions.excludeBrowserFlags,
         chromiumBinary: devOptions.chromiumBinary,
         geckoBinary: devOptions.geckoBinary,
         instanceId: devOptions.instanceId,

programs/develop/webpack/webpack-types.ts

@@ -337,6 +337,7 @@ export interface CommonWebpackOptions {
   output: OutputConfig
   preferences?: Record<string, unknown>
   browserFlags?: string[]
+  excludeBrowserFlags?: string[]
   /**
    * Workspace/dependency packages that should be transpiled from source.
    * Useful for monorepos where package exports point to TS/TSX files.