fix: refactor runners, add linting (#72)

Author: wesleytodd

package-lock.json

@@ -5,6 +5,8 @@
   "scripts": {
     "setup": "npm i",
     "test": "echo \"Error: no test specified\" && exit 1",
+    "lint": "npm run --workspaces --if-present lint",
+    "lint:fix": "npm run --workspaces --if-present lint:fix",
     "load": "expf load",
     "test:load": "expf load --test=@expressjs/perf-load-example",
     "test:load:node": "expf load --test=@expressjs/perf-load-node-http",

package.json

@@ -30,4 +30,3 @@ export default async function main (_opts = {}) {
 
   return run(opts);
 }
-

packages/autocannon/index.mjs

@@ -3,13 +3,18 @@
   "version": "1.0.0",
   "main": "index.mjs",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "lint": "semistandard",
+    "lint:fix": "semistandard --fix"
   },
   "keywords": [],
   "author": "",
   "license": "ISC",
   "description": "",
   "dependencies": {
     "autocannon": "^8.0.0"
+  },
+  "devDependencies": {
+    "semistandard": "^17.0.0"
   }
 }

packages/autocannon/package.json

@@ -16,7 +16,7 @@ export default function main (_opts = {}) {
     console.log(help());
     return;
   }
-  return new Promise(async (resolve, reject) => {
+  return new Promise((resolve, reject) => {
     throw new Error('not yet implemented');
   });
-};
+}

packages/cli/bench.mjs

@@ -25,11 +25,14 @@ export default function main (_opts = {}, resultA, resultB) {
     console.log(help());
     return;
   }
+  // eslint-disable-next-line no-async-promise-executor
   return new Promise(async (resolve, reject) => {
     const opts = {
       cwd: normalize(join(import.meta.dirname, '..', '..')),
       ..._opts
     };
+    // TODO: these are considered syntax errors according to semistandard, despite clearly not being so
+    // likely an old version of eslint parsing under the hood. Just leaving for now.
     const a = (await import(join(opts.cwd, resultA), { with: { type: 'json' } })).default.clientResults;
     const b = (await import(join(opts.cwd, resultB), { with: { type: 'json' } })).default.clientResults;
     const comp = compare(a, b);

packages/cli/compare.mjs

@@ -3,7 +3,9 @@
   "version": "1.0.0",
   "main": "bin/expf.mjs",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "lint": "semistandard",
+    "lint:fix": "semistandard --fix"
   },
   "bin": {
     "expf": "./bin/expf.sh"
@@ -16,5 +18,8 @@
     "@pkgjs/nv": "^0.2.2",
     "autocannon": "^8.0.0",
     "autocannon-compare": "^0.4.0"
+  },
+  "devDependencies": {
+    "semistandard": "^17.0.0"
   }
 }

packages/cli/package.json

@@ -11,4 +11,4 @@ export function collectMetadata () {
     type: os.type(),
     version: os.version()
   };
-}
+}

packages/metadata/index.mjs

@@ -4,7 +4,9 @@
   "version": "1.0.0",
   "main": "index.mjs",
   "scripts": {
-    "test": "semistandard"
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "lint": "semistandard",
+    "lint:fix": "semistandard --fix"
   },
   "keywords": [],
   "author": "",

packages/metadata/package.json

@@ -7,10 +7,15 @@
     "./get-query": "./get-query.mjs"
   },
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "echo \"Error: no test specified\" && exit 1",
+    "lint": "semistandard",
+    "lint:fix": "semistandard --fix"
   },
   "keywords": [],
   "author": "",
   "license": "ISC",
-  "description": ""
+  "description": "",
+  "devDependencies": {
+    "semistandard": "^17.0.0"
+  }
 }