fix: remove unused config (#32)

* Ignore empty payload

* remove max transactions

* Apply suggestion from @gemini-code-assist[bot]

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* make debug log

* fmt

* clippy

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: tac0turtle <[email protected]>

Author: 3 people

bin/ev-reth/src/builder.rs

@@ -47,10 +47,7 @@ pub struct RollkitPayloadBuilderBuilder {
 impl RollkitPayloadBuilderBuilder {
     /// Create a new builder with rollkit args
     pub fn new(_args: &RollkitArgs) -> Self {
-        let config = RollkitPayloadBuilderConfig {
-            max_transactions: 1000,
-            min_gas_price: 1_000_000_000, // 1 Gwei
-        };
+        let config = RollkitPayloadBuilderConfig::new();
         info!("Created Rollkit payload builder with config: {:?}", config);
         Self { config }
     }
@@ -132,7 +129,7 @@ where
             cached_reads: _,
             config,
             cancel: _,
-            best_payload,
+            best_payload: _,
         } = args;
         let PayloadConfig {
             parent_header,
@@ -177,15 +174,6 @@ where
             None,                 // No blob sidecar for rollkit
         );
 
-        if let Some(best) = best_payload {
-            if built_payload.fees() <= best.fees() {
-                return Ok(BuildOutcome::Aborted {
-                    fees: built_payload.fees(),
-                    cached_reads: CachedReads::default(),
-                });
-            }
-        }
-
         Ok(BuildOutcome::Better {
             payload: built_payload,
             cached_reads: CachedReads::default(),

crates/evolve/src/rpc/txpool.rs

@@ -1,5 +1,6 @@
 use alloy_primitives::Bytes;
 use async_trait::async_trait;
+use jsonrpsee::tracing::debug;
 use jsonrpsee_core::RpcResult;
 use jsonrpsee_proc_macros::rpc;
 use reth_transaction_pool::{PoolTransaction, TransactionPool};
@@ -70,6 +71,7 @@ where
             total += sz;
         }
 
+        debug!("get_txs returning {} transactions", selected_txs.len());
         Ok(selected_txs)
     }
 }

crates/node/src/config.rs

@@ -1,53 +1,25 @@
 use serde::{Deserialize, Serialize};
 
 /// Configuration for the Rollkit payload builder
-#[derive(Debug, Clone, Serialize, Deserialize)]
-pub struct RollkitPayloadBuilderConfig {
-    /// Maximum number of transactions to include in a payload
-    pub max_transactions: usize,
-    /// Minimum gas price for transactions
-    pub min_gas_price: u64,
-}
-
-impl Default for RollkitPayloadBuilderConfig {
-    fn default() -> Self {
-        Self {
-            max_transactions: 1000,
-            min_gas_price: 1_000_000_000, // 1 Gwei
-        }
-    }
-}
+#[derive(Debug, Clone, Serialize, Deserialize, Default)]
+pub struct RollkitPayloadBuilderConfig {}
 
 impl RollkitPayloadBuilderConfig {
     /// Creates a new instance of `RollkitPayloadBuilderConfig`
-    pub const fn new(max_transactions: usize, min_gas_price: u64) -> Self {
-        Self {
-            max_transactions,
-            min_gas_price,
-        }
+    pub const fn new() -> Self {
+        Self {}
     }
 
     /// Validates the configuration
     pub const fn validate(&self) -> Result<(), ConfigError> {
-        if self.max_transactions == 0 {
-            return Err(ConfigError::InvalidMaxTransactions);
-        }
-
-        if self.min_gas_price == 0 {
-            return Err(ConfigError::InvalidMinGasPrice);
-        }
-
         Ok(())
     }
 }
 
 /// Errors that can occur during configuration validation
 #[derive(Debug, thiserror::Error)]
 pub enum ConfigError {
-    #[error("Invalid max transactions value")]
-    /// Invalid maximum transactions value.
-    InvalidMaxTransactions,
-    #[error("Invalid min gas price value")]
-    /// Invalid minimum gas price value.
-    InvalidMinGasPrice,
+    /// Invalid configuration provided
+    #[error("Invalid config")]
+    InvalidConfig,
 }