fix clippy

Author: tac0turtle

Cargo.lock

@@ -94,6 +94,7 @@ alloy-primitives = { version = "1.2.0", default-features = false }
 alloy-consensus = { version = "1.0.17", default-features = false }
 alloy-rlp = { version = "0.3", default-features = false }
 alloy-genesis = { version = "1.0.17", default-features = false }
+alloy-rpc-types-txpool = { version = "1.0.17", default-features = false }
 
 # Core dependencies
 eyre = "0.6"
@@ -105,6 +106,7 @@ thiserror = "2.0"
 async-trait = "0.1"
 futures = "0.3"
 clap = { version = "4.5", features = ["derive", "env"] }
+jsonrpsee = "0.25.1"
 
 # Additional dependencies
 reqwest = { version = "0.11", features = ["json"] }

Cargo.toml

@@ -17,10 +17,7 @@ use alloy_rpc_types::engine::{
 use clap::Parser;
 use lumen_rollkit::{
     config::RollkitConfig,
-    rpc::{
-        create_rollkit_txpool_module,
-        txpool::{RollkitTxpoolApiImpl, RollkitTxpoolApiServer},
-    },
+    rpc::txpool::{RollkitTxpoolApiImpl, RollkitTxpoolApiServer},
 };
 use reth_ethereum::{
     chainspec::ChainSpec,
@@ -177,7 +174,7 @@ fn main() {
                 .extend_rpc_modules(move |ctx| {
                     // Build custom txpool RPC
                     let rollkit_txpool = RollkitTxpoolApiImpl::new(
-                        ctx.pool(),
+                        ctx.pool().clone(),
                         RollkitConfig::default().max_txpool_bytes,
                     );
 

bin/lumen/src/main.rs

@@ -14,17 +14,21 @@ reth-payload-primitives.workspace = true
 reth-primitives.workspace = true
 reth-primitives-traits.workspace = true
 reth-engine-primitives.workspace = true
+reth-transaction-pool.workspace = true
 
 # Alloy dependencies
 alloy-rpc-types-engine.workspace = true
 alloy-primitives.workspace = true
 alloy-eips.workspace = true
 alloy-consensus.workspace = true
 alloy-rlp.workspace = true
+alloy-rpc-types-txpool.workspace = true
 
 # Core dependencies
 serde = { workspace = true, features = ["derive"] }
 thiserror.workspace = true
+async-trait.workspace = true
+jsonrpsee.workspace = true
 
 [dev-dependencies]
 serde_json.workspace = true

crates/rollkit/Cargo.toml

@@ -7,7 +7,6 @@ pub const DEFAULT_MAX_TXPOOL_BYTES: u64 = 1_980 * 1024; // 1.98 MB = 2,027,520 b
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct RollkitConfig {
     /// Maximum bytes of transactions to return from the txpool
-    #[serde(default = "default_max_txpool_bytes")]
     pub max_txpool_bytes: u64,
 }
 
@@ -20,12 +19,8 @@ impl Default for RollkitConfig {
 }
 
 impl RollkitConfig {
-    /// Creates a new RollkitConfig with the given max txpool bytes
+    /// Creates a new `RollkitConfig` with the given max txpool bytes
     pub const fn new(max_txpool_bytes: u64) -> Self {
         Self { max_txpool_bytes }
     }
 }
-
-fn default_max_txpool_bytes() -> u64 {
-    DEFAULT_MAX_TXPOOL_BYTES
-}

crates/rollkit/src/config.rs

@@ -2,14 +2,14 @@ use alloy_primitives::{hex::encode as hex_encode, Address};
 use alloy_rlp::encode as rlp_encode;
 use alloy_rpc_types_txpool::TxpoolContent;
 use async_trait::async_trait;
-use jsonrpsee::{core::RpcResult, proc_macros::rpc, RpcModule};
+use jsonrpsee::{core::RpcResult, proc_macros::rpc};
 use reth_transaction_pool::{TransactionPool, ValidPoolTransaction};
 use std::collections::BTreeMap;
 
 /// Rollkit txpool RPC API trait
 #[rpc(server, namespace = "txpoolExt")]
 pub trait RollkitTxpoolApi {
-    /// Get transactions from the pool up to the configured max_bytes limit
+    /// Get transactions from the pool up to the configured `max_bytes` limit
     #[method(name = "getTxs")]
     async fn get_txs(&self) -> RpcResult<TxpoolContent<String>>;
 }
@@ -31,7 +31,10 @@ impl<Pool> RollkitTxpoolApiImpl<Pool> {
 }
 
 /// Creates a new Rollkit txpool RPC module
-pub fn create_rollkit_txpool_module<Pool>(pool: Pool, max_bytes: u64) -> RollkitTxpoolApiImpl<Pool>
+pub const fn create_rollkit_txpool_module<Pool>(
+    pool: Pool,
+    max_bytes: u64,
+) -> RollkitTxpoolApiImpl<Pool>
 where
     Pool: TransactionPool + Send + Sync + 'static,
 {
@@ -43,7 +46,7 @@ impl<Pool> RollkitTxpoolApiServer for RollkitTxpoolApiImpl<Pool>
 where
     Pool: TransactionPool + Send + Sync + 'static,
 {
-    /// Returns a Geth-style TxpoolContent with raw RLP hex strings.
+    /// Returns a Geth-style `TxpoolContent` with raw RLP hex strings.
     async fn get_txs(&self) -> RpcResult<TxpoolContent<String>> {
         //------------------------------------------------------------------//
         // 1. Iterate pending txs and stop once we hit the byte cap         //