fix tests

Author: julienrbrt

block/manager_test.go

@@ -541,13 +541,6 @@ func TestManager_execValidate(t *testing.T) {
 		require.NoError(err)
 	})
 
-	t.Run("invalid header (ValidateBasic fails)", func(t *testing.T) {
-		state, header, data, _ := makeValid()
-		header.ProposerAddress = []byte("bad") // breaks proposer address check
-		err := m.execValidate(state, header, data)
-		require.ErrorContains(err, "invalid header")
-	})
-
 	t.Run("header/data mismatch (types.Validate fails)", func(t *testing.T) {
 		state, header, data, _ := makeValid()
 		data.Metadata.ChainID = "otherchain" // breaks types.Validate

block/sync_test.go

@@ -53,24 +53,26 @@ func setupManagerForSyncLoopTest(t *testing.T, initialState types.State) (
 
 	// Manager setup
 	m := &Manager{
-		store:         mockStore,
-		exec:          mockExec,
-		config:        cfg,
-		genesis:       *genesisDoc,
-		lastState:     initialState,
-		lastStateMtx:  new(sync.RWMutex),
-		logger:        logging.Logger("test"),
-		headerCache:   cache.NewCache[types.SignedHeader](),
-		dataCache:     cache.NewCache[types.Data](),
-		headerInCh:    headerInCh,
-		dataInCh:      dataInCh,
-		headerStoreCh: headerStoreCh,
-		dataStoreCh:   dataStoreCh,
-		retrieveCh:    retrieveCh,
-		daHeight:      &atomic.Uint64{},
-		metrics:       NopMetrics(),
-		headerStore:   &goheaderstore.Store[*types.SignedHeader]{},
-		dataStore:     &goheaderstore.Store[*types.Data]{},
+		store:                    mockStore,
+		exec:                     mockExec,
+		config:                   cfg,
+		genesis:                  *genesisDoc,
+		lastState:                initialState,
+		lastStateMtx:             new(sync.RWMutex),
+		logger:                   logging.Logger("test"),
+		headerCache:              cache.NewCache[types.SignedHeader](),
+		dataCache:                cache.NewCache[types.Data](),
+		headerInCh:               headerInCh,
+		dataInCh:                 dataInCh,
+		headerStoreCh:            headerStoreCh,
+		dataStoreCh:              dataStoreCh,
+		retrieveCh:               retrieveCh,
+		daHeight:                 &atomic.Uint64{},
+		metrics:                  NopMetrics(),
+		headerStore:              &goheaderstore.Store[*types.SignedHeader]{},
+		dataStore:                &goheaderstore.Store[*types.Data]{},
+		signaturePayloadProvider: types.DefaultSignaturePayloadProvider,
+		validatorHasherProvider:  types.DefaultValidatorHasherProvider,
 	}
 	m.daHeight.Store(initialState.DAHeight)
 
@@ -859,19 +861,21 @@ func TestSyncLoop_MultipleHeadersArriveFirst_ThenData(t *testing.T) {
 	}
 
 	m := &Manager{
-		store:        store,
-		exec:         mockExec,
-		config:       config.DefaultConfig,
-		genesis:      genesis.Genesis{ChainID: initialState.ChainID},
-		lastState:    initialState,
-		lastStateMtx: new(sync.RWMutex),
-		logger:       logging.Logger("test"),
-		headerCache:  cache.NewCache[types.SignedHeader](),
-		dataCache:    cache.NewCache[types.Data](),
-		headerInCh:   headerInCh,
-		dataInCh:     dataInCh,
-		daHeight:     &atomic.Uint64{},
-		metrics:      NopMetrics(),
+		store:                    store,
+		exec:                     mockExec,
+		config:                   config.DefaultConfig,
+		genesis:                  genesis.Genesis{ChainID: initialState.ChainID},
+		lastState:                initialState,
+		lastStateMtx:             new(sync.RWMutex),
+		logger:                   logging.Logger("test"),
+		headerCache:              cache.NewCache[types.SignedHeader](),
+		dataCache:                cache.NewCache[types.Data](),
+		headerInCh:               headerInCh,
+		dataInCh:                 dataInCh,
+		daHeight:                 &atomic.Uint64{},
+		metrics:                  NopMetrics(),
+		signaturePayloadProvider: types.DefaultSignaturePayloadProvider,
+		validatorHasherProvider:  types.DefaultValidatorHasherProvider,
 	}
 	m.daHeight.Store(initialState.DAHeight)