Gère proprement les erreurs de l'organisation dans l'API write

FindOrCreateOrganizationForAPI utilisait find_or_create_by! qui lève
une exception ActiveRecord::RecordInvalid non rescue, remontant en
500. Remplacé par find_or_create_by + context.fail! avec les erreurs
du modèle.

Expose un rendu d'erreur 422 dédié (Organisation invalide) dans le
controller. Refactorise render_interactor_errors via deux constantes
de lookup (SIMPLE_ERRORS, MODEL_ERRORS) pour contenir la complexité.

Author: skelz0r

app/controllers/api/v1/authorization_requests_controller.rb

@@ -1,4 +1,15 @@
 class API::V1::AuthorizationRequestsController < API::V1Controller
+  SIMPLE_ERRORS = {
+    form_not_found: [422, 'Formulaire introuvable', 'Le formulaire demandé est introuvable.'],
+    unauthorized_type: [403, 'Non autorisé', "Vous n'avez pas les droits pour créer ce type de demande."],
+    dead_end_state: [422, 'État non modifiable', "La demande ne peut pas être modifiée dans l'état actuel."]
+  }.freeze
+
+  MODEL_ERRORS = {
+    applicant_errors: 'Demandeur invalide',
+    organization_errors: 'Organisation invalide'
+  }.freeze
+
   before_action -> { doorkeeper_authorize! :read_authorizations }, only: %i[index show]
   before_action -> { doorkeeper_authorize! :write_authorizations }, only: %i[create update]
   before_action :set_authorization_request, only: %i[show update]
@@ -96,19 +107,17 @@ def render_authorization_request(authorization_request, status: :ok)
   end
 
   def render_interactor_errors(result)
-    if result.form_not_found
-      render_error(422, title: 'Formulaire introuvable', detail: 'Le formulaire demandé est introuvable.')
-    elsif result.unauthorized_type
-      render_error(403, title: 'Non autorisé', detail: "Vous n'avez pas les droits pour créer ce type de demande.")
-    elsif result.dead_end_state
-      render_error(422, title: 'État non modifiable', detail: "La demande ne peut pas être modifiée dans l'état actuel.")
-    elsif result.invalid_keys.present?
-      render_invalid_keys_errors(result.invalid_keys)
-    elsif result.applicant_errors.present?
-      render_applicant_errors(result.applicant_errors)
-    else
-      render_generic_error
+    SIMPLE_ERRORS.each do |key, (status, title, detail)|
+      return render_error(status, title:, detail:) if result.public_send(key)
+    end
+
+    return render_invalid_keys_errors(result.invalid_keys) if result.invalid_keys.present?
+
+    MODEL_ERRORS.each do |key, title|
+      return render_model_errors(title, result.public_send(key)) if result.public_send(key).present?
     end
+
+    render_generic_error
   end
 
   def render_invalid_keys_errors(keys)
@@ -118,9 +127,9 @@ def render_invalid_keys_errors(keys)
     render json: { errors: }, status: :unprocessable_content
   end
 
-  def render_applicant_errors(applicant_errors)
-    errors = applicant_errors.full_messages.map do |msg|
-      { status: '422', title: 'Demandeur invalide', detail: msg }
+  def render_model_errors(title, model_errors)
+    errors = model_errors.full_messages.map do |msg|
+      { status: '422', title:, detail: msg }
     end
     render json: { errors: }, status: :unprocessable_content
   end

app/interactors/find_or_create_organization_for_api.rb

@@ -1,10 +1,18 @@
 class FindOrCreateOrganizationForAPI < ApplicationInteractor
   def call
-    context.organization = Organization.find_or_create_by!(
+    context.organization = find_or_create_organization
+
+    return context.fail!(organization_errors: context.organization.errors) unless context.organization.persisted?
+
+    UpdateOrganizationINSEEPayloadJob.perform_later(context.organization.id)
+  end
+
+  private
+
+  def find_or_create_organization
+    Organization.find_or_create_by(
       legal_entity_id: context.siret,
       legal_entity_registry: 'insee_sirene'
     )
-
-    UpdateOrganizationINSEEPayloadJob.perform_later(context.organization.id)
   end
 end

spec/interactors/find_or_create_organization_for_api_spec.rb

@@ -38,5 +38,19 @@
         expect { result }.to have_enqueued_job(UpdateOrganizationINSEEPayloadJob)
       end
     end
+
+    context 'with an invalid siret' do
+      subject(:result) { described_class.call(siret: 'invalid') }
+
+      it { is_expected.to be_a_failure }
+
+      it 'exposes the organization errors' do
+        expect(result.organization_errors).to be_present
+      end
+
+      it 'does not schedule an INSEE payload update' do
+        expect { result }.not_to have_enqueued_job(UpdateOrganizationINSEEPayloadJob)
+      end
+    end
   end
 end