Skip to content

fix: change set to sorted set for dependent route#780

Merged
KirylKurnosenka merged 3 commits intodevelopmentfrom
fix/change_set_to_sorted_set
Mar 23, 2026
Merged

fix: change set to sorted set for dependent route#780
KirylKurnosenka merged 3 commits intodevelopmentfrom
fix/change_set_to_sorted_set

Conversation

@KirylKurnosenka
Copy link
Collaborator

@KirylKurnosenka KirylKurnosenka commented Mar 20, 2026

Applicable issues

Description of changes

DependenRoute is mapped from string to json (and vice versa) for applications and application type schemas, which could lead to the incosistent order in permissions, methods sets and therefore produce redudant activities during system rollback. Example:
Left is before rollback, right is after rollback
image
before rollback:
[{"deployment":{"name":"markdown-extractor-rest","roleLimits":[],"isPublic":true},"rewritePath":false,"paths":["/extract/text"],"methods":["POST"],"upstreams":[{"endpoint":"http://ocr-backend.dial-ocr:80/rest/v1/extract/text","weight":1,"tier":0}],"maxRetryAttempts":1,"order":2147483647,"permissions":["read","write"],"attachmentPaths":{"requestBody":["@.attachment.url"],"responseBody":[]}}]
after rollback:
[{"deployment":{"name":"markdown-extractor-rest","roleLimits":[],"isPublic":true},"rewritePath":false,"paths":["/extract/text"],"methods":["POST"],"upstreams":[{"endpoint":"http://ocr-backend.dial-ocr:80/rest/v1/extract/text","weight":1,"tier":0}],"maxRetryAttempts":1,"order":2147483647,"permissions":["write","read"],"attachmentPaths":{"requestBody":["@.attachment.url"],"responseBody":[]}}]

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ai-dial-actions
Copy link
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

settings.gradle

PackageVersionLicenseIssue Type
com.gradle:common-custom-user-data-gradle-plugin2.1NullUnknown License
com.gradle:develocity-gradle-plugin4.3.1NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
maven/com.gradle:common-custom-user-data-gradle-plugin 2.1 UnknownUnknown
maven/com.gradle:develocity-gradle-plugin 4.3.1 UnknownUnknown

Scanned Files

  • settings.gradle

@ai-dial-actions
Copy link
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

settings.gradle

PackageVersionLicenseIssue Type
com.gradle:common-custom-user-data-gradle-plugin2.1NullUnknown License
com.gradle:develocity-gradle-plugin4.3.1NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
maven/com.gradle:common-custom-user-data-gradle-plugin 2.1 UnknownUnknown
maven/com.gradle:develocity-gradle-plugin 4.3.1 UnknownUnknown

Scanned Files

  • settings.gradle

@ai-dial-actions
Copy link
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

settings.gradle

PackageVersionLicenseIssue Type
com.gradle:common-custom-user-data-gradle-plugin2.1NullUnknown License
com.gradle:develocity-gradle-plugin4.3.1NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
maven/com.gradle:common-custom-user-data-gradle-plugin 2.1 UnknownUnknown
maven/com.gradle:develocity-gradle-plugin 4.3.1 UnknownUnknown

Scanned Files

  • settings.gradle

@KirylKurnosenka KirylKurnosenka merged commit d58edd7 into development Mar 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Audit->System Rollback] In Activities table you should see just relevant changes after System Rollback

3 participants