Deprecated socket_options

[karpetrosyan]

#668 added support for socket options.
Refs: encode/httpx#2811

Because we have a network_backend as a public API, we can now drop socket_options support and just use a custom network_backend instead.

I suggest that we will deprecate socket_options and remove it in httpcore 0.19.0

[lovelydinosaur]

Ah yes I think you've got a good bit of neatening up here.

To clarify first, could you provide before/after examples?...

[lovelydinosaur]

Okay I'll rephrase...

Why do we want to deprecate socket_options?

[karpetrosyan]

We have a powerful network_backend API, which is exactly what we want in such cases. Why should we support additional APIs for doing the same thing?

[lovelydinosaur]

Note: I do think we unneccessarily rushed socket_options support into the API, yes. However it is there now, so if we want to change that we need to work through things carefully so as to not negatively impact our users.

Given that encode/httpx#2716 adds support for socket_options to httpx, are you also suggesting that we drop support for httpx.HTTPTransport(socket_options=...)?

[karpetrosyan]

For now, I just suggest deprecating it in httpcore. I think we are isolated enough to work on such things without thinking about HTTPX.

[karpetrosyan]

I think we just should avoid removing socket_options in 0.18.* versions (because now httpx depends on httpcore>=18 and < 19 versions), so we can deprecate it in 0.18.1 and move to 0.19 without any problems.