Enable more lints (#215)

Enabling some lints for better code quality

Author: bircni

Cargo.toml

@@ -102,6 +102,7 @@ missing_crate_level_docs = "warn"
 # See also clippy.toml
 [workspace.lints.clippy]
 allow_attributes = "warn"
+allow_attributes_without_reason = "warn"
 as_ptr_cast_mut = "warn"
 await_holding_lock = "warn"
 bool_to_int_with_if = "warn"
@@ -133,6 +134,7 @@ expl_impl_clone_on_copy = "warn"
 explicit_deref_methods = "warn"
 explicit_into_iter_loop = "warn"
 explicit_iter_loop = "warn"
+expect_used = "warn"
 fallible_impl_from = "warn"
 filter_map_next = "warn"
 flat_map_option = "warn"
@@ -206,6 +208,7 @@ non_zero_suggestions = "warn"
 nonstandard_macro_braces = "warn"
 option_as_ref_cloned = "warn"
 option_option = "warn"
+or_fun_call = "warn"
 path_buf_push_overwrite = "warn"
 pathbuf_init_then_push = "warn"
 precedence_bits = "warn"

demo/src/app.rs

@@ -131,6 +131,7 @@ impl DemoGallery {
 
                 ui.horizontal(|ui| {
                     ui.label("Tags:");
+                    #[expect(clippy::expect_used, reason = "tags are non-empty strings")]
                     egui_chip::ChipEditBuilder::new(",")
                         .expect("failed to create ChipEditBuilder")
                         .texts(example.tags())

egui_plot/src/items/arrows.rs

@@ -48,7 +48,7 @@ impl<'a> Arrows<'a> {
     /// losing the item's state. You should make sure the name passed to
     /// [`Self::new`] is unique and stable for each item, or set unique and
     /// stable ids explicitly via [`Self::id`].
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.base_mut().name = name.to_string();

egui_plot/src/items/bar_chart.rs

@@ -138,7 +138,7 @@ impl BarChart {
     /// losing the item's state. You should make sure the name passed to
     /// [`Self::new`] is unique and stable for each item, or set unique and
     /// stable ids explicitly via [`Self::id`].
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.base_mut().name = name.to_string();
@@ -278,7 +278,7 @@ impl Bar {
     }
 
     /// Name of this bar chart element.
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.name = name.to_string();

egui_plot/src/items/box_plot.rs

@@ -104,7 +104,7 @@ impl BoxPlot {
     /// losing the item's state. You should make sure the name passed to
     /// [`Self::new`] is unique and stable for each item, or set unique and
     /// stable ids explicitly via [`Self::id`].
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.base_mut().name = name.to_string();
@@ -279,7 +279,7 @@ impl BoxElem {
     }
 
     /// Name of this box element.
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.name = name.to_string();

egui_plot/src/items/filled_area.rs

@@ -94,7 +94,7 @@ impl FilledArea {
     /// Name of this plot item.
     ///
     /// This name will show up in the plot legend, if legends are turned on.
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.base_mut().name = name.to_string();

egui_plot/src/items/heatmap.rs

@@ -207,7 +207,7 @@ impl Heatmap {
             let i_rel: f64 = i as f64 / (resolution - 1) as f64;
             if i_rel == 1.0 {
                 // last element
-                *color = *base_colors.last().expect("Base colors should not be empty");
+                *color = base_colors[base_colors.len() - 1];
             } else {
                 let base_index_float: f64 = i_rel * (base_colors.len() - 1) as f64;
                 let base_index: usize = base_index_float as usize;
@@ -277,7 +277,7 @@ impl Heatmap {
     /// This name will show up in the plot legend, if legends are turned on.
     /// Multiple heatmaps may share the same name, in which case they will
     /// also share an entry in the legend.
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.name = name.to_string();

egui_plot/src/items/line.rs

@@ -74,7 +74,7 @@ impl HLine {
     /// losing the item's state. You should make sure the name passed to
     /// [`Self::new`] is unique and stable for each item, or set unique and
     /// stable ids explicitly via [`Self::id`].
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.base_mut().name = name.to_string();
@@ -209,7 +209,7 @@ impl VLine {
     /// losing the item's state. You should make sure the name passed to
     /// [`Self::new`] is unique and stable for each item, or set unique and
     /// stable ids explicitly via [`Self::id`].
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.base_mut().name = name.to_string();

egui_plot/src/items/mod.rs

@@ -1,5 +1,8 @@
 //! Contains items that can be added to a plot at some plot coordinates.
-#![expect(clippy::type_complexity)] // TODO(#163): simplify some of the callback types with type aliases
+#![expect(
+    clippy::type_complexity,
+    reason = "TODO(#163): simplify some of the callback types with type aliases"
+)]
 
 use std::ops::RangeInclusive;
 
@@ -234,7 +237,7 @@ fn add_rulers_and_text(
     }
 
     // Text
-    let text = text.unwrap_or({
+    let text = text.unwrap_or_else(|| {
         let mut text = elem.name().to_owned(); // could be empty
 
         if show_values {

egui_plot/src/items/plot_image.rs

@@ -91,7 +91,7 @@ impl PlotImage {
     /// losing the item's state. You should make sure the name passed to
     /// [`Self::new`] is unique and stable for each item, or set unique and
     /// stable ids explicitly via [`Self::id`].
-    #[expect(clippy::needless_pass_by_value)]
+    #[expect(clippy::needless_pass_by_value, reason = "to allow various string types")]
     #[inline]
     pub fn name(mut self, name: impl ToString) -> Self {
         self.base_mut().name = name.to_string();