Skip to content

[schema-coverage] Add acceptance coverage for elasticstack_elasticsearch_ingest_processor_sort #2330

@github-actions

Description

@github-actions

Entity: elasticstack_elasticsearch_ingest_processor_sort\nEntity type: data source\nImplementation directory: internal/elasticsearch/ingest\n\n## Attributes with no coverage\n- id (Computed, TypeString) — not asserted directly.\n- target_field (Optional, TypeString) — not configured, not asserted.\n- description (Optional, TypeString) — not configured, not asserted.\n- if (Optional, TypeString) — not configured, not asserted.\n- ignore_failure (Optional, TypeBool, default false) — only covered indirectly via json; not asserted as a schema attribute.\n- on_failure (Optional, TypeList) — not configured, not asserted.\n- tag (Optional, TypeString) — not configured, not asserted.\n\n## Attributes with poor coverage\n- order (Optional, TypeString, default asc)\n - Observed: configured once as \"desc\" and only verified through json.\n - Gaps: no attribute-level assertion, single value only, no default-path coverage for omitted order.\n- json (Computed, TypeString)\n - Observed: asserted once through CheckResourceJSON in internal/elasticsearch/ingest/processor_sort_data_source_test.go.\n - Gaps: single configuration only; no coverage showing target_field or other optional fields in rendered JSON.\n- field (Required, TypeString)\n - Observed: configured once as \"array_field_to_sort\" and asserted once.\n - Gaps: single value only.\n\n## Prioritized top gaps\n1. Add coverage for target_field and verify it appears in both schema state and rendered JSON.\n2. Add default coverage for omitted order and explicit attribute-level assertions for both asc and desc paths.\n3. Add coverage for description, if, tag, ignore_failure, and on_failure.\n4. Add explicit id assertion.\n5. Add a second configuration to exercise different field values.\n\n## Concrete acceptance-test additions\n- Add a new fixture under internal/elasticsearch/ingest/testdata/TestAccDataSourceIngestProcessorSort/ that sets:\n - field = \"items\"\n - target_field = \"sorted_items\"\n - description = \"sort array\"\n - if = \"ctx.items != null\"\n - tag = \"sort-items\"\n - ignore_failure = true\n - on_failure = [jsonencode({ append = { field = \"errors\", value = \"sort_failed\" } })]\n- Add one step omitting order and assert the default order = \"asc\" at the schema level plus JSON output.\n- Keep a second step with order = \"desc\" and assert it explicitly with TestCheckResourceAttr.\n- Assert target_field, description, if, tag, ignore_failure, on_failure.#, and id.\n- Extend CheckResourceJSON expectations for both defaulted and fully populated configurations.\n\n## Relevant files\n- Schema: internal/elasticsearch/ingest/processor_sort_data_source.go\n- Acceptance test: internal/elasticsearch/ingest/processor_sort_data_source_test.go\n- Current config fixture: internal/elasticsearch/ingest/testdata/TestAccDataSourceIngestProcessorSort/read/main.tf

Generated by Schema Coverage Rotation · ● 21.1K ·

Metadata

Metadata

Assignees

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions