O2 linter fixes 3

Author: ekryshen

Common/CCDB/EventSelectionParams.cxx

@@ -174,7 +174,7 @@ EventSelectionParams::EventSelectionParams(int system, int run)
   }
 }
 
-void EventSelectionParams::DisableOutOfBunchPileupCuts()
+void EventSelectionParams::disableOutOfBunchPileupCuts()
 {
   selectionBarrel[kNoV0MOnVsOfPileup] = 0;
   selectionBarrel[kNoSPDOnVsOfPileup] = 0;
@@ -192,15 +192,15 @@ void EventSelectionParams::DisableOutOfBunchPileupCuts()
   selectionMuonWithoutPileupCuts[kNoV0PFPileup] = 0;
 }
 
-void EventSelectionParams::SetOnVsOfParams(float newV0MOnVsOfA, float newV0MOnVsOfB, float newSPDOnVsOfA, float newSPDOnVsOfB)
+void EventSelectionParams::setOnVsOfParams(float newV0MOnVsOfA, float newV0MOnVsOfB, float newSPDOnVsOfA, float newSPDOnVsOfB)
 {
   fV0MOnVsOfA = newV0MOnVsOfA;
   fV0MOnVsOfB = newV0MOnVsOfB;
   fSPDOnVsOfA = newSPDOnVsOfA;
   fSPDOnVsOfB = newSPDOnVsOfB;
 }
 
-bool* EventSelectionParams::GetSelection(int iSelection)
+bool* EventSelectionParams::getSelection(int iSelection)
 {
   if (iSelection == 0) {
     return selectionBarrel;

Common/CCDB/EventSelectionParams.h

@@ -8,6 +8,7 @@
 // In applying this license CERN does not waive the privileges and immunities
 // granted to it by virtue of its status as an Intergovernmental Organization
 // or submit itself to any jurisdiction.
+
 /// \file EventSelectionParams.h
 /// \brief Event selection parameters
 ///
@@ -85,9 +86,9 @@ class EventSelectionParams
 {
  public:
   explicit EventSelectionParams(int system = 0, int run = 2);
-  void DisableOutOfBunchPileupCuts();
-  void SetOnVsOfParams(float newV0MOnVsOfA, float newV0MOnVsOfB, float newSPDOnVsOfA, float newSPDOnVsOfB);
-  bool* GetSelection(int iSelection);
+  void disableOutOfBunchPileupCuts();
+  void setOnVsOfParams(float newV0MOnVsOfA, float newV0MOnVsOfB, float newSPDOnVsOfA, float newSPDOnVsOfB);
+  bool* getSelection(int iSelection);
 
   bool selectionBarrel[o2::aod::evsel::kNsel];
   bool selectionMuonWithPileupCuts[o2::aod::evsel::kNsel];

Common/TableProducer/eventSelection.cxx

@@ -328,7 +328,7 @@ struct BcSelectionTask {
     }
 
     // bc loop
-    for (const auto bc : bcs) {
+    for (const auto& bc : bcs) {
       uint32_t alias{0};
       // workaround for pp2022 (trigger info is shifted by -294 bcs)
       int32_t triggerBcId = mapGlobalBCtoBcId[bc.globalBC() + triggerBcShift];
@@ -917,7 +917,7 @@ struct EventSelectionTask {
       if (bc.has_foundFT0())
         vAmpFT0CperColl[colIndex] = bc.foundFT0().sumAmpC();
 
-      int64_t TFid = (foundGlobalBC - bcSOR) / nBCsPerTF;
+      int64_t tfId = (foundGlobalBC - bcSOR) / nBCsPerTF;
       int64_t rofId = (foundGlobalBC + nBCsPerOrbit - rofOffset) / rofLength;
 
       // ### for in-ROF occupancy
@@ -928,7 +928,7 @@ struct EventSelectionTask {
         int64_t thisBC = vFoundGlobalBC[minColIndex];
         // check if this is still the same TF
         int64_t thisTFid = (thisBC - bcSOR) / nBCsPerTF;
-        if (thisTFid != TFid)
+        if (thisTFid != tfId)
           break;
         // int thisRofIdInTF = (thisBC - rofOffset) / rofLength;
         int64_t thisRofId = (thisBC + nBCsPerOrbit - rofOffset) / rofLength;
@@ -944,7 +944,7 @@ struct EventSelectionTask {
       while (maxColIndex < cols.size()) {
         int64_t thisBC = vFoundGlobalBC[maxColIndex];
         int64_t thisTFid = (thisBC - bcSOR) / nBCsPerTF;
-        if (thisTFid != TFid)
+        if (thisTFid != tfId)
           break;
         int64_t thisRofId = (thisBC + nBCsPerOrbit - rofOffset) / rofLength;
         if (thisRofId != rofId)
@@ -961,7 +961,7 @@ struct EventSelectionTask {
         int64_t thisBC = vFoundGlobalBC[minColIndex];
         // check if this is still the same TF
         int64_t thisTFid = (thisBC - bcSOR) / nBCsPerTF;
-        if (thisTFid != TFid)
+        if (thisTFid != tfId)
           break;
         int64_t thisRofId = (thisBC + nBCsPerOrbit - rofOffset) / rofLength;
         if (thisRofId == rofId - 1)
@@ -987,7 +987,7 @@ struct EventSelectionTask {
         int64_t thisBC = vFoundGlobalBC[minColIndex];
         // check if this is still the same TF
         int64_t thisTFid = (thisBC - bcSOR) / nBCsPerTF;
-        if (thisTFid != TFid)
+        if (thisTFid != tfId)
           break;
         float dt = (thisBC - foundGlobalBC) * bcNS; // ns
         // check if we are within the chosen time range
@@ -1002,7 +1002,7 @@ struct EventSelectionTask {
       while (maxColIndex < cols.size()) {
         int64_t thisBC = vFoundGlobalBC[maxColIndex];
         int64_t thisTFid = (thisBC - bcSOR) / nBCsPerTF;
-        if (thisTFid != TFid)
+        if (thisTFid != tfId)
           break;
         float dt = (thisBC - foundGlobalBC) * bcNS; // ns
         if (dt > timeWinOccupancyCalcMaxNS)