fix: skip biodata redirect for administrators

Author: Saqib-Rafique

common/djangoapps/student/helpers.py

@@ -296,6 +296,9 @@ def get_biodata_profile_redirect_url(user):
     if not getattr(user, 'username', None):
         return None
 
+    if getattr(user, 'is_staff', False) or getattr(user, 'is_superuser', False):
+        return None
+
     if _has_submitted_biodata_declaration(user):
         return None
 

common/djangoapps/student/tests/test_helpers.py

@@ -236,6 +236,23 @@ def test_keeps_login_redirect_when_biodata_declaration_is_complete(self, mock_ge
 
         assert next_page == '/dashboard'
 
+    @skip_unless_lms
+    @override_settings(PROFILE_MICROFRONTEND_URL='http://profile-mfe')
+    @patch('common.djangoapps.student.helpers.apps.get_model')
+    def test_keeps_login_redirect_for_administrator_when_biodata_declaration_is_missing(self, mock_get_model):
+        """
+        Test administrators are not redirected to biodata even when their declaration is missing.
+        """
+        user = SimpleNamespace(username='test-user', is_staff=True, is_superuser=False)
+
+        req = self.request.get(settings.LOGIN_URL)
+        req.META["HTTP_ACCEPT"] = "text/html"
+
+        next_page = get_next_url_for_login_page(req, user=user)
+
+        mock_get_model.assert_not_called()
+        assert next_page == '/dashboard'
+
     @skip_unless_lms
     @override_settings(PROFILE_MICROFRONTEND_URL='http://profile-mfe')
     @patch('common.djangoapps.student.helpers.apps.get_model')