-
Notifications
You must be signed in to change notification settings - Fork 27
Open
Description
Whenever a plugin goal is set to a property which is only set within profiles the following warning is being emitted:
Invalid goal for this plugin: ${myProperty}
Seems that interpolation is not correctly done in
Line 146 in 205df36
| private Optional<Diagnostic> internalValidateGoal(DiagnosticRequest diagnosticReq, PluginDescriptor pluginDescriptor) { |
This can be reproduced for example with https://github.com/apache/jackrabbit-filevault, which contains
<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>com.diffplug.spotless</groupId>
<artifactId>spotless-maven-plugin</artifactId>
<version>3.1.0</version>
<executions>
<execution>
<id>spotless-format</id>
<goals>
<goal>${spotless.action}</goal>
</goals>
<phase>process-sources</phase>
</execution>
</executions>
</plugin>
...
<profiles>
...
<profile>
<id>format-check</id>
<activation>
<property>
<name>env.CI</name>
</property>
</activation>
<properties>
<spotless.action>check</spotless.action>
</properties>
</profile>
<profile>
<id>format</id>
<activation>
<property>
<name>!env.CI</name>
</property>
</activation>
<properties>
<spotless.action>apply</spotless.action>
</properties>
</profile>
...
(in https://github.com/apache/jackrabbit-filevault/blob/master/parent/pom.xml)
This emits
Invalid goal for this plugin: ${spotless.action}
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels