Fix some compile warnings (#2919)

* Fix some compile warnings
* Some classes made final
* JPA entities made not serializable

Signed-off-by: Avgustin Marinov <[email protected]>

Author: avgustinmm

hawkbit-artifact/hawkbit-artifact-api/src/main/java/org/eclipse/hawkbit/artifact/exception/FileSizeQuotaExceededException.java

@@ -9,6 +9,8 @@
  */
 package org.eclipse.hawkbit.artifact.exception;
 
+import java.io.Serial;
+
 import lombok.EqualsAndHashCode;
 import lombok.ToString;
 import org.eclipse.hawkbit.exception.AbstractServerRtException;
@@ -21,6 +23,9 @@
 @ToString(callSuper = true)
 public class FileSizeQuotaExceededException extends AbstractServerRtException {
 
+    @Serial
+    private static final long serialVersionUID = 1L;
+
     private static final String MAX_ARTIFACT_SIZE_EXCEEDED = "Maximum artifact size (%s) exceeded.";
     private static final SpServerError errorType = SpServerError.SP_FILE_SIZE_QUOTA_EXCEEDED;
 

hawkbit-artifact/hawkbit-artifact-api/src/main/java/org/eclipse/hawkbit/artifact/exception/StorageQuotaExceededException.java

@@ -9,6 +9,8 @@
  */
 package org.eclipse.hawkbit.artifact.exception;
 
+import java.io.Serial;
+
 import lombok.EqualsAndHashCode;
 import lombok.ToString;
 import org.eclipse.hawkbit.exception.AbstractServerRtException;
@@ -21,6 +23,9 @@
 @ToString(callSuper = true)
 public class StorageQuotaExceededException extends AbstractServerRtException {
 
+    @Serial
+    private static final long serialVersionUID = 1L;
+
     private static final String MAX_ARTIFACT_SIZE_TOTAL_EXCEEDED = "Storage quota exceeded, %s left.";
     private static final SpServerError errorType = SpServerError.SP_STORAGE_QUOTA_EXCEEDED;
 

hawkbit-ddi/hawkbit-ddi-security/src/main/java/org/eclipse/hawkbit/security/controller/Authenticator.java

@@ -11,6 +11,7 @@
 
 import static org.eclipse.hawkbit.context.AccessContext.asTenant;
 
+import java.io.Serial;
 import java.util.Collection;
 import java.util.List;
 import java.util.Objects;
@@ -61,6 +62,9 @@ protected Authentication authenticatedController(final String tenant, final Stri
         @EqualsAndHashCode(callSuper = true)
         private static class AuthenticatedController extends AbstractAuthenticationToken {
 
+            @Serial
+            private static final long serialVersionUID = 1L;
+
             private static final Collection<GrantedAuthority> CONTROLLER_AUTHORITY =
                     List.of(new SimpleGrantedAuthority(SpRole.CONTROLLER_ROLE));
             private final String controllerId;

hawkbit-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/ConfigurableRabbitListenerContainerFactory.java

@@ -16,19 +16,13 @@
 import org.springframework.util.ErrorHandler;
 
 /**
- * {@link RabbitListenerContainerFactory} that can be configured through
- * hawkBit's {@link AmqpProperties}.
+ * {@link RabbitListenerContainerFactory} that can be configured through hawkBit's {@link AmqpProperties}.
  */
-public class ConfigurableRabbitListenerContainerFactory extends SimpleRabbitListenerContainerFactory {
+public final class ConfigurableRabbitListenerContainerFactory extends SimpleRabbitListenerContainerFactory {
 
     private final int declarationRetries;
 
     /**
-     * Constructor.
-     *
-     * @param missingQueuesFatal the missingQueuesFatal to set.
-     * @param declarationRetries The number of retries
-     * @param errorHandler the error handler which should be use
      * @see SimpleMessageListenerContainer#setMissingQueuesFatal
      */
     public ConfigurableRabbitListenerContainerFactory(

hawkbit-dmf/hawkbit-dmf-amqp/src/main/java/org/eclipse/hawkbit/amqp/RequeueExceptionStrategy.java

@@ -32,7 +32,7 @@
  */
 @ToString
 @Slf4j
-class RequeueExceptionStrategy implements FatalExceptionStrategy {
+final class RequeueExceptionStrategy implements FatalExceptionStrategy {
 
     private final List<FatalExceptionStrategy> fatalExceptionStrategies = new ArrayList<>();
 

hawkbit-dmf/hawkbit-dmf-amqp/src/test/java/org/eclipse/hawkbit/amqp/AmqpMessageHandlerServiceTest.java

@@ -43,7 +43,6 @@
 import org.eclipse.hawkbit.repository.model.ActionProperties;
 import org.eclipse.hawkbit.repository.model.DistributionSet;
 import org.eclipse.hawkbit.repository.model.Target;
-import org.eclipse.hawkbit.repository.model.TenantConfigurationValue;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.ExtendWith;
@@ -427,8 +426,8 @@ void quotaExceeded() {
      * Test next update is provided on finished action
      */
     @Test
+    @SuppressWarnings("unchecked")
     void lookupNextUpdateActionAfterFinished() {
-
         // Mock
         final Action action = createActionWithTarget(22L);
         when(controllerManagementMock.findActionWithDetails(anyLong())).thenReturn(Optional.of(action));
@@ -460,7 +459,7 @@ void lookupNextUpdateActionAfterFinished() {
      * Test feedback code is persisted in messages when provided with DmfActionUpdateStatus
      */
     @Test
-    void feedBackCodeIsPersistedInMessages() throws IllegalAccessException {
+    void feedBackCodeIsPersistedInMessages() {
         // Mock
         final Action action = createActionWithTarget(22L);
         when(controllerManagementMock.findActionWithDetails(anyLong())).thenReturn(Optional.of(action));
@@ -471,9 +470,7 @@ void feedBackCodeIsPersistedInMessages() throws IllegalAccessException {
         final MessageProperties messageProperties = createMessageProperties(MessageType.EVENT);
         messageProperties.setHeader(MessageHeaderKey.TOPIC, EventTopic.UPDATE_ACTION_STATUS.name());
 
-        final DmfActionUpdateStatus actionUpdateStatus = new DmfActionUpdateStatus(
-                23L, DmfActionStatus.RUNNING, null, 2L, null, 12);
-
+        final DmfActionUpdateStatus actionUpdateStatus = new DmfActionUpdateStatus(23L, DmfActionStatus.RUNNING, null, 2L, null, 12);
         final Message message = createMessage(actionUpdateStatus, messageProperties);
 
         // test